-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Insights: rust-lang/rust-clippy
Overview
Could not load contribution data
Please try again later
33 Pull requests merged by 10 people
-
simplify
too_many_args
#15462 merged
Aug 23, 2025 -
Check config options in test suite
#15397 merged
Aug 23, 2025 -
Detect infinite loop in
async fn
not returning!
#15545 merged
Aug 23, 2025 -
Check that no profile is present in
Cargo.toml
files#15544 merged
Aug 23, 2025 -
Use
.cargo/config.toml
for local compilation options#15543 merged
Aug 23, 2025 -
extract
bool_comparison
to a separate file#15499 merged
Aug 23, 2025 -
Fix
derivable_impls
suggests wrongly onderive_const
#15535 merged
Aug 22, 2025 -
bool_comparison
: no longer lint on!x != y
#15498 merged
Aug 22, 2025 -
bool_comparison: fix incorrect suggestion with
>
/<
and macros#15513 merged
Aug 22, 2025 -
fix
manual_is_ascii_check
: also add explicit type when lintingmatches!
#15492 merged
Aug 22, 2025 -
ptr_as_ptr: fix incorrect suggestion with
pointer::cast
and macros#15514 merged
Aug 22, 2025 -
try_err
: clean-up#15526 merged
Aug 22, 2025 -
is_expr_identity_of_pat
: simplify using(unordered_)over
#15450 merged
Aug 22, 2025 -
Add 1.89 beta-accepted changes to changelog
#15534 merged
Aug 22, 2025 -
Better check for
assign_op_pattern
inconst
context#15532 merged
Aug 22, 2025 -
use
is_{type,path}_diagnostic_item
in more places#15527 merged
Aug 22, 2025 -
Rustup
#15531 merged
Aug 22, 2025 -
Fix
unnecessary_safety_comment
does not lint for the first line#15354 merged
Aug 22, 2025 -
chore: remove redundant word in comment
#15530 merged
Aug 22, 2025 -
renamed_function_params
: clean-up a bit#15524 merged
Aug 21, 2025 -
Add myself back to reviewer rotation
#15523 merged
Aug 21, 2025 -
too_many_lines
: only highlight the function signature#15461 merged
Aug 21, 2025 -
Lint to stable/beta lint docs page in diagnostics
#14547 merged
Aug 21, 2025 -
len_zero
: clean-up a bit#15518 merged
Aug 21, 2025 -
ptr_arg
: clean-up a bit#15507 merged
Aug 21, 2025 -
Do not replace
match
byif
if any arm contains a binding#15352 merged
Aug 21, 2025 -
extract
duplicate_underscore_argument
, and move it intofunctions
#15508 merged
Aug 21, 2025 -
Cut needless mut
#15512 merged
Aug 18, 2025 -
msrv
: replace nestedif
s with guard clauses#15490 merged
Aug 18, 2025 -
Do not suggest to use implicit
DerefMut
onManuallyDrop
reached through unions#14387 merged
Aug 18, 2025 -
clean-up
collapsible_if
a bit#15503 merged
Aug 17, 2025 -
Misc
clippy_dev
changes#14896 merged
Aug 17, 2025 -
similar_names
stop linting for 3-char names#15100 merged
Aug 16, 2025
12 Pull requests opened by 6 people
-
Refactor run and mtime functions: safer error handling, cleaner struc…
#15505 opened
Aug 17, 2025 -
`clippy_utils`: make `peel_*_ty_refs` class of functions a bit more consistent
#15515 opened
Aug 19, 2025 -
Add configuration option to allow `unreachable!` in test functions
#15517 opened
Aug 20, 2025 -
`get_diagnostic_item` in a bunch more places
#15519 opened
Aug 20, 2025 -
`non_canonical_impls`: split the main `check` function
#15520 opened
Aug 20, 2025 -
clean-up `transmute_int_to_non_zero`
#15521 opened
Aug 20, 2025 -
Fix `branches-sharing-code` suggests wrongly on `const` and `static`
#15522 opened
Aug 21, 2025 -
use `get_diagnostic_item` in even more places
#15528 opened
Aug 21, 2025 -
Activate `range-diff` feature of triagebot
#15538 opened
Aug 22, 2025 -
Fix `match_single_binding` suggests wrongly inside tuple
#15539 opened
Aug 22, 2025 -
ptr_cast_constness: avoid suggesting unresolvable method call
#15540 opened
Aug 23, 2025 -
`entry`: link to `Entry` API if can't make a suggestion
#15546 opened
Aug 23, 2025
19 Issues closed by 8 people
-
`collapsible_if` ignore gated out lines between two if
#15502 closed
Aug 23, 2025 -
`infinite_loop` no longer lints async functions
#15541 closed
Aug 23, 2025 -
Weird trigger condition for wrong_self_convention
#9038 closed
Aug 23, 2025 -
`derivable_impls` FN when enum is qualified with `Self`
#15536 closed
Aug 22, 2025 -
Correct manual impl Default
#15493 closed
Aug 22, 2025 -
`bool_comparison` triggers twice on the same code
#15367 closed
Aug 22, 2025 -
`bool_comparison` mangles macro invocations
#15497 closed
Aug 22, 2025 -
manual_is_ascii_check causes error[E0282]: type annotations needed
#15326 closed
Aug 22, 2025 -
`ptr-as-ptr` confused by `ptr::addr_of_mut!` macro
#15232 closed
Aug 22, 2025 -
Custom handling for const-stability of assign operators in `assign_op_pattern` lint should be removed
#15285 closed
Aug 22, 2025 -
`unnecessary_safety_comment` does not lint the first item of a module without a body
#14554 closed
Aug 22, 2025 -
`unnecessary_safety_comment` does not lint for the first line
#14553 closed
Aug 22, 2025 -
False positive: empty_line_after_outer_attribute incorrectly flags deny attribute
#15525 closed
Aug 21, 2025 -
`too_many_lines` should only highlight the function signature, and not the entire function body
#15430 closed
Aug 21, 2025 -
`clippy::missing_panics_doc` still triggering even with `expect` or `allow` on individual unwraps
#14534 closed
Aug 21, 2025 -
`match_bool` will suggetion will introduce untinitialized binding that still existed in the match arm
#15351 closed
Aug 21, 2025 -
collapsible_if suggestions are not safe
#7965 closed
Aug 19, 2025 -
Clippy suggests broken code when modifying union fields behind ManuallyDrop
#14386 closed
Aug 18, 2025 -
Stop triggering `similar_names` for 3-character names
#14869 closed
Aug 16, 2025
7 Issues opened by 7 people
-
`match_single_binding` can't add semicolon if expression is returned
#15537 opened
Aug 22, 2025 -
ptr::write_volatile and read_volatile are not well-defined on compound types
#15529 opened
Aug 21, 2025 -
significant_drop_tightening false positive on loops
#15510 opened
Aug 18, 2025 -
How to build my own clippy and install it for official stable rust version like 1.88
#15509 opened
Aug 18, 2025 -
`ptr_arg` doesn't work with `impl AsRef<Path>`
#15506 opened
Aug 17, 2025 -
`ptr_arg` should trigger for `Option<&PathBuf>`
#15504 opened
Aug 17, 2025
68 Unresolved conversations
Sometimes conversations happen on old items that aren’t yet closed. Here is a list of all the Issues and Pull Requests with unresolved conversations.
-
Verify that versions in the changelog match the lint definitions
#14821 commented on
Aug 21, 2025 • 6 new comments -
`unnecessary_operation`: don't suggest autofixes on composite types with fields of uncertain types
#15460 commented on
Aug 22, 2025 • 6 new comments -
fix `equatable_if_let`: don't suggest `=` in const context
#15482 commented on
Aug 22, 2025 • 5 new comments -
Fix `never_loop` forget to remove `break` in nested loop
#15356 commented on
Aug 21, 2025 • 4 new comments -
Suggest naming types before using explicit type names
#14996 commented on
Aug 21, 2025 • 3 new comments -
`let_unit_with_type_underscore`: make early-pass
#15458 commented on
Aug 22, 2025 • 1 new comment -
Fix `redundant_closure` suggests wrongly with deref overload
#15077 commented on
Aug 21, 2025 • 0 new comments -
Fix `large_stack_frames` FP on compiler generated targets
#15101 commented on
Aug 21, 2025 • 0 new comments -
handle another type of collapsible if-statement
#15104 commented on
Aug 17, 2025 • 0 new comments -
List possible values for configuration enums
#15216 commented on
Aug 21, 2025 • 0 new comments -
`map_identity`: suggest making the variable mutable when necessary
#15268 commented on
Aug 22, 2025 • 0 new comments -
`clippy_dev`: changes to parsing code
#15270 commented on
Aug 17, 2025 • 0 new comments -
fix `unnecessary_semicolon`: FN on `#[feature(stmt_expr_attributes)]`
#15481 commented on
Aug 22, 2025 • 0 new comments -
`unused_enumerate_index`: move to loops lint pass
#15279 commented on
Aug 22, 2025 • 0 new comments -
Split methods pass into a new crate take 2
#15280 commented on
Aug 17, 2025 • 0 new comments -
Split loops pass into a new crate
#15291 commented on
Aug 17, 2025 • 0 new comments -
Split matches pass into a new crate
#15292 commented on
Aug 17, 2025 • 0 new comments -
Split casts pass into a new crate
#15293 commented on
Aug 17, 2025 • 0 new comments -
Fix `missing_inline_in_public_items` fail to fulfill `expect` in `--test` build
#15320 commented on
Aug 21, 2025 • 0 new comments -
`needless_return`: do not lint on proc macros
#15329 commented on
Aug 23, 2025 • 0 new comments -
fix: `unnested_or_patterns` FP on structs with only shorthand field pats
#15343 commented on
Aug 22, 2025 • 0 new comments -
clean-up `unnested_or_patterns`
#15344 commented on
Aug 22, 2025 • 0 new comments -
`ptr_as_ptr`: move to `if`
#15480 commented on
Aug 22, 2025 • 0 new comments -
feat: `manual_rotate` also recognize non-consts
#15402 commented on
Aug 23, 2025 • 0 new comments -
overhaul `mut_mut`
#15417 commented on
Aug 22, 2025 • 0 new comments -
WIP: `mut_mut`: generalize the from-expansion check
#15419 commented on
Aug 22, 2025 • 0 new comments -
`double_parens`: add structured suggestions, fix bug
#15420 commented on
Aug 22, 2025 • 0 new comments -
fix: `semicolon_inside_block` don't fire if block is surrounded by parens
#15421 commented on
Aug 22, 2025 • 0 new comments -
`cast_slice_from_raw_parts`: check for implicit cast to raw slice pointer
#15437 commented on
Aug 23, 2025 • 0 new comments -
`unnecessary_mut_passed`: add structured suggestion
#15438 commented on
Aug 22, 2025 • 0 new comments -
Rewrite `unwrap_in_result` lint
#15445 commented on
Aug 23, 2025 • 0 new comments -
Add `needless_conversion_for_trait` lint
#15451 commented on
Aug 19, 2025 • 0 new comments -
split `cast_ptr_alignment`
#15479 commented on
Aug 22, 2025 • 0 new comments -
Fix `semicolon_inside_block` FP when attribute over expr is not enabled
#15476 commented on
Aug 21, 2025 • 0 new comments -
clean-up `ptr_cast_constness`
#15478 commented on
Aug 22, 2025 • 0 new comments -
New lint: `concealed_obvious_default`
#15037 commented on
Aug 17, 2025 • 0 new comments -
Split `suboptimal_flops` into smaller lints
#6867 commented on
Aug 20, 2025 • 0 new comments -
Clippy contains about useless .into() in macro generated code
#7845 commented on
Aug 19, 2025 • 0 new comments -
`drop` on non-`Drop` types is useful defensive programming
#11650 commented on
Aug 19, 2025 • 0 new comments -
False positive in clippy::unnecessary_literal_unwrap if variable is later used for struct construction
#11381 commented on
Aug 19, 2025 • 0 new comments -
clippy::question_mark suggests code that is semantically different to the original
#7924 commented on
Aug 19, 2025 • 0 new comments -
Clippy finds less clear fix for manual_memcpy
#7931 commented on
Aug 19, 2025 • 0 new comments -
make let-chains collapsable-if allow-by-default
#15134 commented on
Aug 19, 2025 • 0 new comments -
duplicated_attributes: false positive with apistos crate
#13238 commented on
Aug 19, 2025 • 0 new comments -
duplicated_attributes: false positive with async-graphql Interface derive
#12923 commented on
Aug 19, 2025 • 0 new comments -
What about placeholders?
#1081 commented on
Aug 18, 2025 • 0 new comments -
redundant_closure suggests wrong fix when the function being called is not Copy
#1608 commented on
Aug 17, 2025 • 0 new comments -
`unnecessary_unwrap` false negative of Option variable in struct
#15321 commented on
Aug 17, 2025 • 0 new comments -
Rust API Guideline: Functions minimize assumptions about parameters by using generics
#1794 commented on
Aug 17, 2025 • 0 new comments -
New lint: clone on arguments taken by reference
#2074 commented on
Aug 17, 2025 • 0 new comments -
`needless_pass_by_ref_mut` should not trigger when values derived from the `&mut` are used in an unsafe block
#13172 commented on
Aug 17, 2025 • 0 new comments -
Incorrect clippy::derivable_impls in the presence of conditional compilation
#13160 commented on
Aug 16, 2025 • 0 new comments -
add new lint: `rest_when_destructuring_struct`
#15000 commented on
Aug 21, 2025 • 0 new comments -
WIP: New lint: `duplicate_match_guards`
#14986 commented on
Aug 22, 2025 • 0 new comments -
Automatically set MSRV for code under `#[cfg(version)]`
#14940 commented on
Aug 17, 2025 • 0 new comments -
WIP: New lint: `needless_path_new`
#14895 commented on
Aug 22, 2025 • 0 new comments -
fix(or_fun_call): respect MSRV for unwrap_or_default suggestion
#14885 commented on
Aug 17, 2025 • 0 new comments -
Rework `module_inception`
#14753 commented on
Aug 17, 2025 • 0 new comments -
Soft rename `clippy::all` to `clippy::default`
#14689 commented on
Aug 17, 2025 • 0 new comments -
[Minor perf] Avoid unnecessary allocations
#14509 commented on
Aug 17, 2025 • 0 new comments -
fix `option_if_let_else` when `Err` variant is ignored
#14429 commented on
Aug 17, 2025 • 0 new comments -
add `default_mismatches_new` lint
#14234 commented on
Aug 17, 2025 • 0 new comments -
`incompatible_msrv` does not work with unit tests
#15369 commented on
Aug 22, 2025 • 0 new comments -
False "missing_const_in_fn" for a function that consumes `self`
#8874 commented on
Aug 22, 2025 • 0 new comments -
Migrate to `span_clippy_lint`
#7797 commented on
Aug 22, 2025 • 0 new comments -
enable inheriting of `clippy.toml`
#1295 commented on
Aug 22, 2025 • 0 new comments -
`needless_continue` false positive
#14550 commented on
Aug 21, 2025 • 0 new comments -
unused_async doesn't trigger if the function is passed into another function
#13466 commented on
Aug 20, 2025 • 0 new comments