WIP: New lint: duplicate_match_guards
#14986
Open
+523
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bd9de96 to
c7f0188
Compare
c7f0188 to
71c4b42
Compare
8bd7cbe to
a86397c
Compare
duplicate_match_guardduplicate_match_guards
fab6b13 to
1a5e31b
Compare
1a5e31b to
d6e58a9
Compare
ada4a
commented
Aug 10, 2025
| }; | ||
|
|
||
| if let ExprKind::If(cond, then, None) = arm_body_expr.kind | ||
| && eq_expr_value(cx, guard, cond.peel_drop_temps()) |
There was a problem hiding this comment.
Since the lint is directed at copy-paste errors, maybe we should make this stricter, and make sure that the expr are "syntactically" equal, and don't just evaluate to the result.
| } | ||
| declare_lint_pass!(DuplicateMatchGuards => [DUPLICATE_MATCH_GUARDS]); | ||
|
|
||
| impl<'tcx> LateLintPass<'tcx> for DuplicateMatchGuards { |
There was a problem hiding this comment.
Now that I think of it, this lint doesn't really type information, so it could be made early-pass I think?
they are not really necessary, since the match body already has its own
This reverts commit 1b44da7. it can be seen that things like comments are not included in this reduced span
NB: this doesn't suggest removing the inner body's curlies since there are no outer ones
required by the naming guidelines
previously, we suggested removing: - everything from the start of `arm_body_expr` to the start of `then` - and everything from the end of `then` to the end of `arm_body_expr` but that should be the same as just replacing `arm_body_expr` with `then` we seem to get some more lines with trailing spaces, but that's probably not that big of a deal...
d6e58a9 to
3e4ace9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14971
WIP because:
eq_expr_valuetakes care of impure function calls?changelog: new lint: [
duplicate_match_guards]