Skip to content

Cut needless mut #15512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2025
Merged

Cut needless mut #15512

merged 1 commit into from
Aug 18, 2025

Conversation

nickdrozd
Copy link
Contributor

changelog:none

@rustbot
Copy link
Collaborator

rustbot commented Aug 18, 2025

r? @blyxyas

rustbot has assigned @blyxyas.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 18, 2025
@blyxyas
Copy link
Member

blyxyas commented Aug 18, 2025

Thanks for the contribution! did you use an automated tool / linter or was it manual? We might want to repeat this in the future (or even implement something similar into CI)

Copy link
Member

@blyxyas blyxyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@blyxyas blyxyas added this pull request to the merge queue Aug 18, 2025
Merged via the queue into rust-lang:master with commit 9a2076e Aug 18, 2025
11 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 18, 2025
@nickdrozd
Copy link
Contributor Author

Thanks for the contribution! did you use an automated tool / linter or was it manual? We might want to repeat this in the future (or even implement something similar into CI)

Yes, I used this amazing Rust linter called Clippy 😆 Actually it is just the Nursery lint needless_pass_by_ref_mut. Probably would be a good to enable it as widely as possible.

I looked and it seems there is no global lint configuration? Locally I have it set up to run in the whole workspace. Could be useful.

(A more extreme option would be to enable needless_pass_by_ref_mut by default.)

@nickdrozd nickdrozd deleted the cut-needless-mut branch August 18, 2025 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants