Skip to content

clean-up collapsible_if a bit #15503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 17, 2025
Merged

clean-up collapsible_if a bit #15503

merged 4 commits into from
Aug 17, 2025

Conversation

ada4a
Copy link
Contributor

@ada4a ada4a commented Aug 16, 2025

changelog: none

@rustbot
Copy link
Collaborator

rustbot commented Aug 16, 2025

r? @llogiq

rustbot has assigned @llogiq.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 16, 2025
llogiq
llogiq approved these changes Aug 17, 2025
View reviewed changes
Copy link
Contributor

@llogiq llogiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, small improvements, easy to review.

Are you interested in doing larger refactorings? There might be some lints that would benefit.

@llogiq llogiq added this pull request to the merge queue Aug 17, 2025
Merged via the queue into rust-lang:master with commit feb18ca Aug 17, 2025
11 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 17, 2025
@ada4a ada4a deleted the collapsible-if-cleanup branch August 17, 2025 15:54
@ada4a
Copy link
Contributor Author

ada4a commented Aug 17, 2025

Are you interested in doing larger refactorings?

Of course! These small things are what I stumble upon when looking into an issue for a particular lint, and I upstream them as separate PRs only when I end up being unable to fix the actual issue 😅

When I've looked at a couple of related lints (#15475, #15477, #15478), I sometimes notice some more global things: #15479, #15480

There might be some lints that would benefit.

If you have some particular ones in mind, do let me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llogiq llogiq llogiq approved these changes

Assignees

@llogiq llogiq

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ada4a @rustbot @llogiq