Skip to content

non_canonical_impls: split the main check function #15520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

non_canonical_impls: split the main check function #15520

wants to merge 18 commits into from
+287 −308

Conversation

ada4a
Copy link
Contributor

@ada4a ada4a commented Aug 20, 2025

this is based #15519, but mainly to avoid gnarly rebase conflicts later

changelog: none

@rustbot
Copy link
Collaborator

rustbot commented Aug 20, 2025

r? @Alexendoo

rustbot has assigned @Alexendoo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 20, 2025
@ada4a
Copy link
Contributor Author

ada4a commented Aug 20, 2025

r? clippy

@rustbot rustbot assigned blyxyas and unassigned Alexendoo Aug 20, 2025
@ada4a ada4a force-pushed the non_canonical_impls branch from 9981625 to c0dd48b Compare August 20, 2025 21:27
ada4a added 18 commits August 22, 2025 15:03
@ada4a
get_diagnostic_name in other places
6322b15
@ada4a
higher: use get_diagnostic_name
123bc5e
@ada4a
misc: destruct args directly
9aea2f5 
avoids bounds checks
@ada4a
misc: pull condition into guard
99fc4f5 
`None` is the fallback case anyway
@ada4a
misc: return earlier on name = None
6934f67
@ada4a
non_octal_unix_permissions: get_diagnostic_name once
3c6895c
@ada4a
misc: reorder to have struct first, then its method
b934e68
@ada4a
redundant_clone: partially inline is_type_diagnostic_item
dca603c 
to be able to reuse `did`
@ada4a
len_zero: use get_diagnostic_name
c91801a
@ada4a
misc: pull another condition into match arm
301a6dc
@ada4a
non_canonical_impls: save diagnostic name to a variable
5e1ed8e
@ada4a
misc: don't bother checking the other case
b15751d 
`trait_name` can only be _one_ of those at the same time
@ada4a
entry: use get_diagnostic_item
03356c0
@ada4a
misc: rewrite as if let
af32759
@ada4a
misc: match in multiple steps
5844333
@ada4a
create let-chain
a095acf
@ada4a
extract helper functions
9139a7e 
too many lines no more!
@ada4a
use match
e10a7a2 
imo it's a bit more clear than checking for the same thing (`expr.kind`)
in multiple branches
@ada4a ada4a force-pushed the non_canonical_impls branch from c0dd48b to e10a7a2 Compare August 22, 2025 13:32
@rustbot
Copy link
Collaborator

rustbot commented Aug 23, 2025

☔ The latest upstream changes (possibly 35fb26f) made this pull request unmergeable. Please resolve the merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@blyxyas blyxyas

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ada4a @rustbot @Alexendoo @blyxyas