Skip to content

Conversation

picnixz
Copy link
Member

@picnixz picnixz commented Aug 22, 2025

This one backports #136570 (9e5cebd) and #136762 (c504f62). However, since HACL* HMAC is only present in 3.14, there are a few helpers that were not needed.

…in tests (pythonGH-136570)

(cherry picked from commit 9e5cebd)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
…ests (python#136762)

- Fix `hashlib_helper.block_algorithm` where the dummy functions were incorrectly defined.
- Rename `hashlib_helper.HashAPI` to `hashlib_helper.HashInfo` and add more helper methods.
- Simplify `hashlib_helper.requires_*()` functions.
- Rewrite some private helpers in `hashlib_helper`.
- Remove `find_{builtin,openssl}_hashdigest_constructor()` as they are no more needed and were
  not meant to be public in the first place.
- Fix some tests in `test_hashlib` when FIPS mode is on.
@picnixz
Copy link
Member Author

picnixz commented Aug 22, 2025

Ok, I managed to actually live without those helpers. In the future, if I need to backport tests, I'll reconsider this PR but there would be too many things to change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant