Skip to content

gh-136547: allow to temporarily disable hash algorithms in tests #136570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 13, 2025
Merged

gh-136547: allow to temporarily disable hash algorithms in tests #136570

merged 4 commits into from
Jul 13, 2025

Conversation

picnixz
Copy link
Member

@picnixz picnixz commented Jul 12, 2025 •
edited by bedevere-app bot
Loading

@picnixz picnixz requested review from gpshead and tiran as code owners July 12, 2025 10:58
@bedevere-app bedevere-app bot mentioned this pull request Jul 12, 2025
Closed
@picnixz picnixz force-pushed the feat/test/hashlib-disable-136547 branch from 7788d60 to 19792cb Compare July 12, 2025 11:11
@picnixz
Copy link
Member Author

picnixz commented Jul 12, 2025

!buildbot FIPS only

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @picnixz for commit 4c36842 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136570%2Fmerge

The command will test the builders whose names match following regular expression: FIPS only

The builders matched are:

  • AMD64 RHEL8 FIPS Only Blake2 Builtin Hash PR
  • AMD64 CentOS9 FIPS Only Blake2 Builtin Hash PR

@picnixz picnixz marked this pull request as draft July 12, 2025 13:53
@picnixz
Copy link
Member Author

picnixz commented Jul 12, 2025

!buildbot FIPS

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @picnixz for commit 879cc73 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136570%2Fmerge

The command will test the builders whose names match following regular expression: FIPS

The builders matched are:

  • AMD64 CentOS9 FIPS Only Blake2 Builtin Hash PR
  • AMD64 RHEL8 FIPS Only Blake2 Builtin Hash PR
  • AMD64 CentOS9 FIPS No Builtin Hashes PR
  • AMD64 RHEL8 FIPS No Builtin Hashes PR

@picnixz picnixz self-assigned this Jul 12, 2025
@picnixz picnixz marked this pull request as ready for review July 12, 2025 19:46
@picnixz picnixz merged commit 9e5cebd into python:main Jul 13, 2025
48 of 50 checks passed
@picnixz picnixz deleted the feat/test/hashlib-disable-136547 branch July 13, 2025 08:58
picnixz added a commit to picnixz/cpython that referenced this pull request Jul 13, 2025
@picnixz
pythongh-136547: allow to temporarily disable hash algorithms in tests (
6475357 
python#136570)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@picnixz @taegyunkim
pythongh-136547: allow to temporarily disable hash algorithms in tests (
864b5ff 
python#136570)
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@picnixz @Agent-Hellboy
pythongh-136547: allow to temporarily disable hash algorithms in tests (
70ce39e 
python#136570)
@picnixz picnixz added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Aug 22, 2025
@miss-islington-app
Copy link

Thanks @picnixz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington-app
Copy link

Thanks @picnixz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 22, 2025
@picnixz @miss-islington
pythongh-136547: allow to temporarily disable hash algorithms in tests (
aedc371 
pythonGH-136570)

(cherry picked from commit 9e5cebd)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@miss-islington-app
Copy link

Sorry, @picnixz, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 9e5cebd56d06e35faeca166813215d72f2f8906a 3.13

@bedevere-app
Copy link

bedevere-app bot commented Aug 22, 2025

GH-138052 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Aug 22, 2025
@picnixz
Copy link
Member Author

picnixz commented Aug 22, 2025

I need to backport this PR and its fix for tests.

picnixz added a commit to picnixz/cpython that referenced this pull request Aug 22, 2025
@picnixz
[3.13] pythongh-136547: allow to temporarily disable hash algorithms …
6f5a82f 
…in tests (pythonGH-136570)

(cherry picked from commit 9e5cebd)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@picnixz picnixz mentioned this pull request Aug 22, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpshead gpshead gpshead approved these changes

@tiran tiran Awaiting requested review from tiran tiran is a code owner

Assignees

@picnixz picnixz

Labels
needs backport to 3.13 bugs and security fixes skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@picnixz @bedevere-bot @gpshead