Skip to content

[3.14] gh-136547: allow to temporarily disable hash algorithms in tests (GH-136570, GH-136762) #138052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Aug 22, 2025

pythonGH-136570)

(cherry picked from commit 9e5cebd)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
…ests (python#136762)

- Fix `hashlib_helper.block_algorithm` where the dummy functions were incorrectly defined.
- Rename `hashlib_helper.HashAPI` to `hashlib_helper.HashInfo` and add more helper methods.
- Simplify `hashlib_helper.requires_*()` functions.
- Rewrite some private helpers in `hashlib_helper`.
- Remove `find_{builtin,openssl}_hashdigest_constructor()` as they are no more needed and were
  not meant to be public in the first place.
- Fix some tests in `test_hashlib` when FIPS mode is on.
@picnixz picnixz self-assigned this Aug 22, 2025
@picnixz picnixz changed the title [3.14] gh-136547: allow to temporarily disable hash algorithms in tests (GH-136570) [3.14] gh-136547: allow to temporarily disable hash algorithms in tests (GH-136570, GH-136762) Aug 22, 2025
@picnixz
Copy link
Member

picnixz commented Aug 22, 2025

Won't merge this one now (#138053 (comment)) but maybe later if I need to.

@picnixz picnixz closed this Aug 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants