Handle empty sizes in AppBar's toolbar layout #6535
Conversation
|
How does size.width end up being zero? A regression test would be useful. If it's possible for size to be 0 x 0 we wouldn't want to introduce a new land mine. |
|
See #5259 |
|
I would rather we only fix this if we actively write a test for every single widget to make sure they all work in 0x0 containers. If we just fix this particular manifestation we'll stop feeling the pain and so we'll stop trying to fix it for the rest of the widgets. |
It's really only the custom layout widgets that are likely to have this sort of bug. Maybe that should be something we do as a matter of routine for custom layout widgets... |
|
By "widget" I meant "UI control", not I think we should test things like check boxes, input fields, app bars, scaffold, etc. |
|
@jason-simmons Per our discussion, I'm going to close this PR for now; it's high on my list to do something about this after I'm done with scrolling. (If someone else wants to take it earlier that's fine too.) |
|
Added a test - PTAL |
|
I think you have to reopen the PR for it to show the updated diff |
|
Recreated this as #6894 |
* Add support for shadows in text. * Use dart:ui Shadow as base class for Shadows * Update lerp definition * Roll engine 3ffa362..84fe4a9 - Text Shadows and update goldens for skia roll. git log 50c2e69..32f417d --oneline --no-merges 32f417d Roll tonic to 077be256142ede39a271385907faadf4fcc62a4d. (#6541) 4ee7725 Revert "Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (#6515)" (#6537) 964acaf Roll src/third_party/skia 646d917d3c71..c6a17104ad68 (1 commits) (#6536) d4bae4c Roll src/third_party/skia 2b2c00f6ec36..646d917d3c71 (1 commits) (#6535) ff93ccf Roll src/third_party/skia 681692726fc0..2b2c00f6ec36 (1 commits) (#6534) a4161c8 Roll src/third_party/skia 23775a2e9736..681692726fc0 (1 commits) (#6532) 116072e Roll src/third_party/skia 7435f2553f53..23775a2e9736 (1 commits) (#6531) ef0b0f6 Roll src/third_party/skia bc7a51e79c5b..7435f2553f53 (1 commits) (#6530) f46b7b9 Roll src/third_party/skia b28db529c866..bc7a51e79c5b (1 commits) (#6529) 9033c39 Roll src/third_party/skia 7e67041a1428..b28db529c866 (1 commits) (#6528) e6887a4 Add missing imports for unicode/utf16.h (#6524) 1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (#6527) a1bbea7 Add a no-op platform view layer. (#6505) 2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (#6526) 75e8752 Fix the Mac embedder build (#6525) 436f970 Add version check for dismissable (#6522) 7767c78 Provide a default GL function resolver in the embedder (#6523) 32841dd Case-insensitive matching of family names for custom fonts (#6519) a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (#6520) f2e7441 An API for loading fonts from a buffer provided by the application (#6508) 05aac0f fix ResourceExtractor npe. (#6461) cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (#6517) 84fe4a9 Re-revert invalid line height tests (#6516) 5f52956 Add support for text shadows (#6385) e44c10c Reland "Share engine layers with the framework" (#6412) (#6468) ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (#6515)
No description provided.