improve flutter create error message #6525

danrubel · 2016-10-25T18:07:23Z

devoncarew · 2016-10-26T12:13:28Z

packages/flutter_tools/lib/src/commands/create.dart

+      printError('Multiple output directories specified.');
+      for (String arg in argResults.rest) {
+        if (arg.startsWith('-')) {
+          printError('Try moving $arg to be immedately following $name');


sp: immediately

devoncarew · 2016-10-26T12:14:00Z

packages/flutter_tools/test/create_test.dart

+      expect(code, 2);
+      expect(logger.errorText, contains('Try moving --pub'));
+    }, overrides:  <Type, dynamic>{
+      Logger : logger,


nit: Logger: logger

devoncarew · 2016-10-26T12:14:06Z

lgtm

* Add support for shadows in text. * Use dart:ui Shadow as base class for Shadows * Update lerp definition * Roll engine 3ffa362..84fe4a9 - Text Shadows and update goldens for skia roll. git log 50c2e69..32f417d --oneline --no-merges 32f417d Roll tonic to 077be256142ede39a271385907faadf4fcc62a4d. (#6541) 4ee7725 Revert "Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (#6515)" (#6537) 964acaf Roll src/third_party/skia 646d917d3c71..c6a17104ad68 (1 commits) (#6536) d4bae4c Roll src/third_party/skia 2b2c00f6ec36..646d917d3c71 (1 commits) (#6535) ff93ccf Roll src/third_party/skia 681692726fc0..2b2c00f6ec36 (1 commits) (#6534) a4161c8 Roll src/third_party/skia 23775a2e9736..681692726fc0 (1 commits) (#6532) 116072e Roll src/third_party/skia 7435f2553f53..23775a2e9736 (1 commits) (#6531) ef0b0f6 Roll src/third_party/skia bc7a51e79c5b..7435f2553f53 (1 commits) (#6530) f46b7b9 Roll src/third_party/skia b28db529c866..bc7a51e79c5b (1 commits) (#6529) 9033c39 Roll src/third_party/skia 7e67041a1428..b28db529c866 (1 commits) (#6528) e6887a4 Add missing imports for unicode/utf16.h (#6524) 1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (#6527) a1bbea7 Add a no-op platform view layer. (#6505) 2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (#6526) 75e8752 Fix the Mac embedder build (#6525) 436f970 Add version check for dismissable (#6522) 7767c78 Provide a default GL function resolver in the embedder (#6523) 32841dd Case-insensitive matching of family names for custom fonts (#6519) a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (#6520) f2e7441 An API for loading fonts from a buffer provided by the application (#6508) 05aac0f fix ResourceExtractor npe. (#6461) cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (#6517) 84fe4a9 Re-revert invalid line height tests (#6516) 5f52956 Add support for text shadows (#6385) e44c10c Reland "Share engine layers with the framework" (#6412) (#6468) ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (#6515)

flutter/engine@4c79e42...2586e94 git log 4c79e42..2586e94 --no-merges --oneline 2586e94 Support all combinations of GetRectsForRange styles (flutter/engine#6591) e78f86e Fix mac builds. Only Linux and Windows require default GL proc resolvers. (flutter/engine#6641) 52e48ab Fix Windows embedding. Appears that flutter#6523 or flutter#6525 introduced a bug for embedder scenarios causing the window native library to be incorrectly initialized and thus incapable of correctly resolving GL functions. This change fixes that. (flutter/engine#6624) c9197e4 Roll src/third_party/skia 25837bf17019..b46c4d0925ad (6 commits) (flutter/engine#6640) 324c21a Roll src/third_party/skia 1b07dffd979d..25837bf17019 (1 commits) (flutter/engine#6639) 5dfbc0a Roll src/third_party/skia e023ae7c5540..1b07dffd979d (1 commits) (flutter/engine#6638) 4a18dff Roll src/third_party/skia ff1aeb953faf..e023ae7c5540 (1 commits) (flutter/engine#6637) 427915e Allow FlutterViewController to specify whether its FlutterView is opaque (flutter/engine#6570) 20c805c Ensure that Scene::toImage renders texture backed images. (flutter/engine#6636) 25d0507 Roll buildtools to 5a9e1b3a0b84a2871f20f85fde665e54a894ba72 (flutter/engine#6633) 4f17d7e Roll src/third_party/skia 327955b1ba19..ff1aeb953faf (13 commits) (flutter/engine#6635) cdd592f Reland 'Pass null instead of 'none' locale' (flutter/engine#6632) 2cd8920 Roll src/third_party/skia b1a002e850e1..327955b1ba19 (12 commits) (flutter/engine#6631) edfe024 13771 - iOS dictation bug (flutter/engine#6607) cadf440 Roll src/third_party/skia b9998cdceec7..b1a002e850e1 (13 commits) (flutter/engine#6626) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

flutter/engine@4c79e42...2586e94 git log 4c79e42..2586e94 --no-merges --oneline 2586e94 Support all combinations of GetRectsForRange styles (flutter/engine#6591) e78f86e Fix mac builds. Only Linux and Windows require default GL proc resolvers. (flutter/engine#6641) 52e48ab Fix Windows embedding. Appears that #6523 or #6525 introduced a bug for embedder scenarios causing the window native library to be incorrectly initialized and thus incapable of correctly resolving GL functions. This change fixes that. (flutter/engine#6624) c9197e4 Roll src/third_party/skia 25837bf17019..b46c4d0925ad (6 commits) (flutter/engine#6640) 324c21a Roll src/third_party/skia 1b07dffd979d..25837bf17019 (1 commits) (flutter/engine#6639) 5dfbc0a Roll src/third_party/skia e023ae7c5540..1b07dffd979d (1 commits) (flutter/engine#6638) 4a18dff Roll src/third_party/skia ff1aeb953faf..e023ae7c5540 (1 commits) (flutter/engine#6637) 427915e Allow FlutterViewController to specify whether its FlutterView is opaque (flutter/engine#6570) 20c805c Ensure that Scene::toImage renders texture backed images. (flutter/engine#6636) 25d0507 Roll buildtools to 5a9e1b3a0b84a2871f20f85fde665e54a894ba72 (flutter/engine#6633) 4f17d7e Roll src/third_party/skia 327955b1ba19..ff1aeb953faf (13 commits) (flutter/engine#6635) cdd592f Reland 'Pass null instead of 'none' locale' (flutter/engine#6632) 2cd8920 Roll src/third_party/skia b1a002e850e1..327955b1ba19 (12 commits) (flutter/engine#6631) edfe024 13771 - iOS dictation bug (flutter/engine#6607) cadf440 Roll src/third_party/skia b9998cdceec7..b1a002e850e1 (13 commits) (flutter/engine#6626) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.

flutter/engine@4c79e42...2586e94 git log 4c79e42..2586e94 --no-merges --oneline 2586e94 Support all combinations of GetRectsForRange styles (flutter/engine#6591) e78f86e Fix mac builds. Only Linux and Windows require default GL proc resolvers. (flutter/engine#6641) 52e48ab Fix Windows embedding. Appears that flutter#6523 or flutter#6525 introduced a bug for embedder scenarios causing the window native library to be incorrectly initialized and thus incapable of correctly resolving GL functions. This change fixes that. (flutter/engine#6624) c9197e4 Roll src/third_party/skia 25837bf17019..b46c4d0925ad (6 commits) (flutter/engine#6640) 324c21a Roll src/third_party/skia 1b07dffd979d..25837bf17019 (1 commits) (flutter/engine#6639) 5dfbc0a Roll src/third_party/skia e023ae7c5540..1b07dffd979d (1 commits) (flutter/engine#6638) 4a18dff Roll src/third_party/skia ff1aeb953faf..e023ae7c5540 (1 commits) (flutter/engine#6637) 427915e Allow FlutterViewController to specify whether its FlutterView is opaque (flutter/engine#6570) 20c805c Ensure that Scene::toImage renders texture backed images. (flutter/engine#6636) 25d0507 Roll buildtools to 5a9e1b3a0b84a2871f20f85fde665e54a894ba72 (flutter/engine#6633) 4f17d7e Roll src/third_party/skia 327955b1ba19..ff1aeb953faf (13 commits) (flutter/engine#6635) cdd592f Reland &flutter#39;Pass null instead of &flutter#39;none&flutter#39; locale&flutter#39; (flutter/engine#6632) 2cd8920 Roll src/third_party/skia b1a002e850e1..327955b1ba19 (12 commits) (flutter/engine#6631) edfe024 13771 - iOS dictation bug (flutter/engine#6607) cadf440 Roll src/third_party/skia b9998cdceec7..b1a002e850e1 (13 commits) (flutter/engine#6626) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC&flutter#39;d on the roll, and stop the roller if necessary.

improve flutter create error message

4aa2079

devoncarew reviewed Oct 26, 2016

View reviewed changes

Dan Rubel added 2 commits October 26, 2016 15:26

fix spelling

3881b3b

Fix formatting

5e6212d

danrubel merged commit 949e27a into flutter:master Oct 26, 2016

danrubel deleted the flutter-create-error-message branch October 27, 2016 12:54

engine-flutter-autoroll mentioned this pull request Oct 23, 2018

Roll engine 4c79e423dc6f..2586e9412257 (15 commits) #23428

Merged

github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

improve flutter create error message #6525

improve flutter create error message #6525

Uh oh!

danrubel commented Oct 25, 2016

Uh oh!

devoncarew Oct 26, 2016

Uh oh!

danrubel Oct 26, 2016

Uh oh!

devoncarew Oct 26, 2016

Uh oh!

danrubel Oct 26, 2016

Uh oh!

devoncarew commented Oct 26, 2016

Uh oh!

Uh oh!

improve flutter create error message #6525

improve flutter create error message #6525

Uh oh!

Conversation

danrubel commented Oct 25, 2016

Uh oh!

devoncarew Oct 26, 2016

Choose a reason for hiding this comment

Uh oh!

danrubel Oct 26, 2016

Choose a reason for hiding this comment

Uh oh!

devoncarew Oct 26, 2016

Choose a reason for hiding this comment

Uh oh!

danrubel Oct 26, 2016

Choose a reason for hiding this comment

Uh oh!

devoncarew commented Oct 26, 2016

Uh oh!

Uh oh!