Use typography from ThemeData in SnackBar #6522
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eliminates hardcoding of Typography.white in favour of picking up the platform default typography from ThemeData.
Hixie
reviewed
Oct 25, 2016
| brightness: Brightness.dark, | ||
| accentColor: theme.accentColor, | ||
| accentColorBrightness: theme.accentColorBrightness | ||
| ); | ||
| List<Widget> children = <Widget>[ |
There was a problem hiding this comment.
Since you have the Theme here, should we also put the theme into the widget tree? That way the content can get to it?
There was a problem hiding this comment.
wait, I see you did already. Never mind.
|
|
GaryQian
added a commit
that referenced
this pull request
Oct 15, 2018
* Add support for shadows in text. * Use dart:ui Shadow as base class for Shadows * Update lerp definition * Roll engine 3ffa362..84fe4a9 - Text Shadows and update goldens for skia roll. git log 50c2e69..32f417d --oneline --no-merges 32f417d Roll tonic to 077be256142ede39a271385907faadf4fcc62a4d. (#6541) 4ee7725 Revert "Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (#6515)" (#6537) 964acaf Roll src/third_party/skia 646d917d3c71..c6a17104ad68 (1 commits) (#6536) d4bae4c Roll src/third_party/skia 2b2c00f6ec36..646d917d3c71 (1 commits) (#6535) ff93ccf Roll src/third_party/skia 681692726fc0..2b2c00f6ec36 (1 commits) (#6534) a4161c8 Roll src/third_party/skia 23775a2e9736..681692726fc0 (1 commits) (#6532) 116072e Roll src/third_party/skia 7435f2553f53..23775a2e9736 (1 commits) (#6531) ef0b0f6 Roll src/third_party/skia bc7a51e79c5b..7435f2553f53 (1 commits) (#6530) f46b7b9 Roll src/third_party/skia b28db529c866..bc7a51e79c5b (1 commits) (#6529) 9033c39 Roll src/third_party/skia 7e67041a1428..b28db529c866 (1 commits) (#6528) e6887a4 Add missing imports for unicode/utf16.h (#6524) 1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (#6527) a1bbea7 Add a no-op platform view layer. (#6505) 2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (#6526) 75e8752 Fix the Mac embedder build (#6525) 436f970 Add version check for dismissable (#6522) 7767c78 Provide a default GL function resolver in the embedder (#6523) 32841dd Case-insensitive matching of family names for custom fonts (#6519) a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (#6520) f2e7441 An API for loading fonts from a buffer provided by the application (#6508) 05aac0f fix ResourceExtractor npe. (#6461) cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (#6517) 84fe4a9 Re-revert invalid line height tests (#6516) 5f52956 Add support for text shadows (#6385) e44c10c Reland "Share engine layers with the framework" (#6412) (#6468) ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (#6515)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminates hardcoding of Typography.white in favour of picking up the
platform default typography from ThemeData.