Skip to content

Make sure that an Autocomplete doesn't crash in 0x0 environment #172732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 20, 2025

Conversation

ahmedsameha1
Copy link
Contributor

This is my attempt to handle #6537 for the Autocomplete UI control.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Jul 24, 2025
Copy link
Contributor

@dkwingsmt dkwingsmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@MitchellGoodwin MitchellGoodwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MitchellGoodwin MitchellGoodwin added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 20, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 20, 2025
Copy link
Contributor

auto-submit bot commented Aug 20, 2025

autosubmit label was removed for flutter/flutter/172732, because Pull request flutter/flutter/172732 is not in a mergeable state.

@dkwingsmt dkwingsmt added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 20, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Aug 20, 2025
Merged via the queue into flutter:master with commit edc8a52 Aug 20, 2025
77 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 20, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 21, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 21, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 21, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 21, 2025
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Aug 21, 2025
flutter/flutter@960d107...d2ac021

2025-08-21 mdebbar@google.com [web] Delete unused utils (flutter/flutter#174160)
2025-08-21 sstrickl@google.com Directly generate a Mach-O dynamic library using gen_snapshot. (flutter/flutter#171626)
2025-08-21 737941+loic-sharma@users.noreply.github.com Update the text input team's issue triage query (flutter/flutter#173999)
2025-08-21 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from V1A1J6uXZ62Q10i9u... to Z-ZaFQ7jAqJ1OrIBf... (flutter/flutter#174170)
2025-08-21 codefu@google.com whitespace (flutter/flutter#174210)
2025-08-21 magder@google.com Add review agent style guidelines to .gemini/styleguide.md (flutter/flutter#174000)
2025-08-20 matanlurey@users.noreply.github.com Move `Linux coverage` back to bringup (flutter/flutter#174171)
2025-08-20 rmacnak@google.com Engine build setup for Android RISCV64. (flutter/flutter#173672)
2025-08-20 41930132+hellohuanlin@users.noreply.github.com [ios][tools] do not print out bonjour key not found in non-verbose mode (flutter/flutter#174001)
2025-08-20 ahmedsameha1@gmail.com Make sure that an Autocomplete doesn't crash in 0x0 environment (flutter/flutter#172732)
2025-08-20 32538273+ValentinVignal@users.noreply.github.com Migrate some files to use `WidgetStateProperty` (flutter/flutter#174109)
2025-08-20 120297255+PurplePolyhedron@users.noreply.github.com Fix `onSelect` called twice in `DropdownMenuFormField` (flutter/flutter#174053)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
SydneyBao pushed a commit to SydneyBao/flutter that referenced this pull request Aug 22, 2025
…ter#172732)

This is my attempt to handle
flutter#6537 for the Autocomplete UI
control.

Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
SydneyBao pushed a commit to SydneyBao/flutter that referenced this pull request Aug 22, 2025
…ter#172732)

This is my attempt to handle
flutter#6537 for the Autocomplete UI
control.

Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants