Directly generate a Mach-O dynamic library using gen_snapshot. #171626
+85
−310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
e4b5867 to
847f50c
Compare
ac999ec to
744d08b
Compare
744d08b to
f884da7
Compare
Instead of generating assembly code that is then compiled to a Mach-O dynamic library, use the new app-aot-macho-dylib output option for gen_snapshot to generate the Mach-O dynamic library without the assembly step.
f884da7 to
53f8e99
Compare
bkonyi
approved these changes
Aug 12, 2025
|
Sorry for the delay on this review, it was missing the |
vashworth
approved these changes
Aug 21, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 21, 2025
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Aug 21, 2025
flutter/flutter@960d107...d2ac021 2025-08-21 mdebbar@google.com [web] Delete unused utils (flutter/flutter#174160) 2025-08-21 sstrickl@google.com Directly generate a Mach-O dynamic library using gen_snapshot. (flutter/flutter#171626) 2025-08-21 737941+loic-sharma@users.noreply.github.com Update the text input team's issue triage query (flutter/flutter#173999) 2025-08-21 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from V1A1J6uXZ62Q10i9u... to Z-ZaFQ7jAqJ1OrIBf... (flutter/flutter#174170) 2025-08-21 codefu@google.com whitespace (flutter/flutter#174210) 2025-08-21 magder@google.com Add review agent style guidelines to .gemini/styleguide.md (flutter/flutter#174000) 2025-08-20 matanlurey@users.noreply.github.com Move `Linux coverage` back to bringup (flutter/flutter#174171) 2025-08-20 rmacnak@google.com Engine build setup for Android RISCV64. (flutter/flutter#173672) 2025-08-20 41930132+hellohuanlin@users.noreply.github.com [ios][tools] do not print out bonjour key not found in non-verbose mode (flutter/flutter#174001) 2025-08-20 ahmedsameha1@gmail.com Make sure that an Autocomplete doesn't crash in 0x0 environment (flutter/flutter#172732) 2025-08-20 32538273+ValentinVignal@users.noreply.github.com Migrate some files to use `WidgetStateProperty` (flutter/flutter#174109) 2025-08-20 120297255+PurplePolyhedron@users.noreply.github.com Fix `onSelect` called twice in `DropdownMenuFormField` (flutter/flutter#174053) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
SydneyBao
pushed a commit
to SydneyBao/flutter
that referenced
this pull request
Aug 22, 2025
…er#171626) Instead of generating assembly code that is then compiled to a Mach-O dynamic library, use the new app-aot-macho-dylib output option for gen_snapshot to generate the Mach-O dynamic library without the assembly step. Related issues: * dart-lang/sdk#43299 * dart-lang/sdk#60307 ## Pre-launch Checklist - [X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [X] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [X] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [X] I signed the [CLA]. - [X] I listed at least one issue that this PR fixes in the description above. - [X] I updated/added relevant documentation (doc comments with `///`). - [X] I added new tests to check the change I am making, or this PR is [test-exempt]. - [X] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [X] All existing and new tests are passing.
SydneyBao
pushed a commit
to SydneyBao/flutter
that referenced
this pull request
Aug 22, 2025
…er#171626) Instead of generating assembly code that is then compiled to a Mach-O dynamic library, use the new app-aot-macho-dylib output option for gen_snapshot to generate the Mach-O dynamic library without the assembly step. Related issues: * dart-lang/sdk#43299 * dart-lang/sdk#60307 ## Pre-launch Checklist - [X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [X] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [X] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [X] I signed the [CLA]. - [X] I listed at least one issue that this PR fixes in the description above. - [X] I updated/added relevant documentation (doc comments with `///`). - [X] I added new tests to check the change I am making, or this PR is [test-exempt]. - [X] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [X] All existing and new tests are passing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of generating assembly code that is then compiled to a Mach-O dynamic library, use the new app-aot-macho-dylib output option for gen_snapshot to generate the Mach-O dynamic library without the assembly step.
Related issues:
Pre-launch Checklist
///).