Page MenuHomePhabricator

FlaggedRevsComponent
ActivePublic

Members (6)

Watchers (12)

Details

Description

Allows for article content management by "editor" and "reviewer" classes (Homepage)

Recent Activity

Yesterday

Jdlrobson-WMF removed a project from T375231: ext-quick-survey-panel is showing up inside mw-fr-revision-details: QuickSurveys.

Looking closer at this the issue and chatting to @Catrope we would suggest using a Popover component instead:
https://doc.wikimedia.org/codex/main/components/demos/popover.html

Wed, Oct 22, 10:56 PM · FlaggedRevs
Tacsipacsi added a comment to T402004: One file in HuWiki cannot be reviewed (error 500).

What is the fiwiki page? (I don’t have access to Logstash.) The huwiki page has been deleted and undeleted between @Boro's recent edit and the previous one, so I think it suffered from T162778: If reviewed page was deleted and then undeleted, page is marked both as reviewed and unreviewed; maybe it’s the same on fiwiki?

Wed, Oct 22, 11:33 AM · Wikimedia-production-error, FlaggedRevs
Ladsgroup added a comment to T402004: One file in HuWiki cannot be reviewed (error 500).

It's still happening in a page in fiwiki: https://logstash.wikimedia.org/goto/59c61188ab8afa294c4b8db12e7cc4c2

Wed, Oct 22, 10:27 AM · Wikimedia-production-error, FlaggedRevs
Novem_Linguae closed T341776: Use Html::* instead of Xml::* in FlaggedRevs as Resolved.

There's no longer any hits in https://codesearch.wmcloud.org/search/?q=Xml%3A%3A&files=&excludeFiles=&repos=Extension%3AFlaggedRevs. I think we can close this.

Wed, Oct 22, 4:27 AM · MW-1.45-notes (1.45.0-wmf.24; 2025-10-21), Patch-For-Review, MW-1.43-notes (1.43.0-wmf.5; 2024-05-14), FlaggedRevs, HTML5
Boro added a comment to T402004: One file in HuWiki cannot be reviewed (error 500).

I was able to review the file with a reviewed edit I made. So the ticket can be closed, I'm just not sure whether you want to keep it open to check the cause or not.

Wed, Oct 22, 3:45 AM · Wikimedia-production-error, FlaggedRevs

Sat, Oct 18

ReleaseTaggerBot added a project to T341776: Use Html::* instead of Xml::* in FlaggedRevs: MW-1.45-notes (1.45.0-wmf.24; 2025-10-21).
Sat, Oct 18, 5:00 PM · MW-1.45-notes (1.45.0-wmf.24; 2025-10-21), Patch-For-Review, MW-1.43-notes (1.43.0-wmf.5; 2024-05-14), FlaggedRevs, HTML5
gerritbot added a comment to T341776: Use Html::* instead of Xml::* in FlaggedRevs.

Change #1196536 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] Replace last use of Xml class with XmlSelect

https://gerrit.wikimedia.org/r/1196536

Sat, Oct 18, 4:20 PM · MW-1.45-notes (1.45.0-wmf.24; 2025-10-21), Patch-For-Review, MW-1.43-notes (1.43.0-wmf.5; 2024-05-14), FlaggedRevs, HTML5

Wed, Oct 15

gerritbot added a project to T341776: Use Html::* instead of Xml::* in FlaggedRevs: Patch-For-Review.
Wed, Oct 15, 10:54 PM · MW-1.45-notes (1.45.0-wmf.24; 2025-10-21), Patch-For-Review, MW-1.43-notes (1.43.0-wmf.5; 2024-05-14), FlaggedRevs, HTML5
gerritbot added a comment to T341776: Use Html::* instead of Xml::* in FlaggedRevs.

Change #1196536 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/FlaggedRevs@master] Replace last use of Xml class with XmlSelect

https://gerrit.wikimedia.org/r/1196536

Wed, Oct 15, 10:54 PM · MW-1.45-notes (1.45.0-wmf.24; 2025-10-21), Patch-For-Review, MW-1.43-notes (1.43.0-wmf.5; 2024-05-14), FlaggedRevs, HTML5
Jdforrester-WMF added a comment to T341776: Use Html::* instead of Xml::* in FlaggedRevs.

This is almost completely done; there's only one hit left per https://codesearch.wmcloud.org/search/?q=Xml%3A%3A&files=&excludeFiles=&repos=Extension%3AFlaggedRevs — a call to Xml::listDropdown() in includes/frontend/specialpages/actions/Stabilization.php.

Wed, Oct 15, 10:08 PM · MW-1.45-notes (1.45.0-wmf.24; 2025-10-21), Patch-For-Review, MW-1.43-notes (1.43.0-wmf.5; 2024-05-14), FlaggedRevs, HTML5

Tue, Oct 14

Zabe moved T399641: Wikimedia\Rdbms\DBQueryError: Error 1054: Unknown column 'cl_target_id' in 'ON'Function: MediaWiki\Pager\IndexPager::buildQueryInfo (PendingChangesPager)Query: SELECT page_namespace,page_title,page_len,rev_len,page_latest,fp from Triage to Done on the DBA board.
Tue, Oct 14, 7:20 PM · DBA, MW-1.45-notes (1.45.0-wmf.10; 2025-07-15), FlaggedRevs, Wikimedia-production-error
Zabe moved T399431: Special:PendingChanges shows wrong and duplicated results if used with category from Triage to Done on the DBA board.
Tue, Oct 14, 7:19 PM · DBA, MW-1.45-notes (1.45.0-wmf.10; 2025-07-15), Regression, FlaggedRevs
Zabe added a project to T399641: Wikimedia\Rdbms\DBQueryError: Error 1054: Unknown column 'cl_target_id' in 'ON'Function: MediaWiki\Pager\IndexPager::buildQueryInfo (PendingChangesPager)Query: SELECT page_namespace,page_title,page_len,rev_len,page_latest,fp: DBA.
Tue, Oct 14, 7:19 PM · DBA, MW-1.45-notes (1.45.0-wmf.10; 2025-07-15), FlaggedRevs, Wikimedia-production-error
Zabe added a project to T399431: Special:PendingChanges shows wrong and duplicated results if used with category: DBA.
Tue, Oct 14, 7:17 PM · DBA, MW-1.45-notes (1.45.0-wmf.10; 2025-07-15), Regression, FlaggedRevs

Mon, Oct 13

Ladsgroup closed T406424: Removed the FlaggedRevs extension on la.ws as Resolved.
Mon, Oct 13, 12:58 PM · Wikimedia-Site-requests, FlaggedRevs

Fri, Oct 10

OKryva-WMF moved T388142: "logevents" list query API fails to load when GlobalBlocking is installed, FlaggedRevs is installed, and $wgBlockDisablesLogin is enabled from Inbox to Later sprints on the Product Safety and Integrity board.
Fri, Oct 10, 9:53 AM · Product Safety and Integrity, Essential-Work, TestMe, GlobalBlocking, FlaggedRevs
OKryva-WMF edited projects for T388142: "logevents" list query API fails to load when GlobalBlocking is installed, FlaggedRevs is installed, and $wgBlockDisablesLogin is enabled, added: Product Safety and Integrity; removed Trust and Safety Product Team.
Fri, Oct 10, 9:53 AM · Product Safety and Integrity, Essential-Work, TestMe, GlobalBlocking, FlaggedRevs

Thu, Oct 9

Jdlrobson-WMF moved T238885: AMC mobile history page layout messed up (FlaggedRevs) from Needs triage to Triaged on the Mobile board.
Thu, Oct 9, 8:28 PM · Mobile, Moderator-Tools-Team, FlaggedRevs, Advanced Mobile Contributions
Jdlrobson-WMF moved T387091: FlaggedRevs incorrectly causes icons to be displayed next to usernames & user-links to be hidden when viewing a page history on mobile (with AMC enabled) from Needs triage to Triaged on the Mobile board.
Thu, Oct 9, 8:15 PM · Mobile, MinervaNeue (Tracking), FlaggedRevs
Novem_Linguae added a comment to T162778: If reviewed page was deleted and then undeleted, page is marked both as reviewed and unreviewed.

I tried several things just now (admin vs logged out editor doing the first edit, article vs redirect, regular title vs unicode title, various combinations of $wgFlaggedRevsOverride and $wgFlaggedRevsProtection, article vs category). Unable to reproduce in localhost.

Thu, Oct 9, 2:02 AM · FlaggedRevs
Bugreporter2 renamed T162778: If reviewed page was deleted and then undeleted, page is marked both as reviewed and unreviewed from If reviewed page was deleted and then undeleted, page is marked both as reviewed and non-reviewed to If reviewed page was deleted and then undeleted, page is marked both as reviewed and unreviewed.
Thu, Oct 9, 1:39 AM · FlaggedRevs

Wed, Oct 8

Tacsipacsi added a comment to T162778: If reviewed page was deleted and then undeleted, page is marked both as reviewed and unreviewed.

Maybe this […] only happens with redirects.

Wed, Oct 8, 10:13 PM · FlaggedRevs
Dreamy_Jazz closed T397887: Indicate the FlaggedRevs revision status on Special:IPContributions as Resolved.
Wed, Oct 8, 11:54 AM · MW-1.45-notes (1.45.0-wmf.22; 2025-10-07), Product Safety and Integrity (Sprint Apfel Strudel (Sep 29 - Oct 17)), Temporary accounts, CheckUser, FlaggedRevs
Novem_Linguae added a comment to T162778: If reviewed page was deleted and then undeleted, page is marked both as reviewed and unreviewed.

According to the screenshots in the merged in ticket, mw-fr-reviewform (the thing in the footer) is showing as reviewed, and mw-indicator-indicator-fr-review-status (the little icon at the top right) is showing as unreviewed.

Wed, Oct 8, 11:22 AM · FlaggedRevs
Tacsipacsi changed the subtype of T162778: If reviewed page was deleted and then undeleted, page is marked both as reviewed and unreviewed from "Task" to "Bug Report".

I think the description of the merged-in task was much better, with clear description of what “marked both as reviewed and non-reviewed” means, so I copy it here for reference:

Wed, Oct 8, 10:19 AM · FlaggedRevs

Tue, Oct 7

Repakr merged T376397: FlaggedRevs: After undeleting a page page becomes checked and uncheked at same time into T162778: If reviewed page was deleted and then undeleted, page is marked both as reviewed and unreviewed.
Tue, Oct 7, 12:23 PM · FlaggedRevs
Repakr merged task T376397: FlaggedRevs: After undeleting a page page becomes checked and uncheked at same time into T162778: If reviewed page was deleted and then undeleted, page is marked both as reviewed and unreviewed.
Tue, Oct 7, 12:23 PM · FlaggedRevs
Maintenance_bot removed a project from T406424: Removed the FlaggedRevs extension on la.ws: Patch-For-Review.
Tue, Oct 7, 10:31 AM · Wikimedia-Site-requests, FlaggedRevs
Ladsgroup added a comment to T406424: Removed the FlaggedRevs extension on la.ws.

Deployed. The logs look okay so far. I will drop the tables next week.

Tue, Oct 7, 10:02 AM · Wikimedia-Site-requests, FlaggedRevs
Stashbot added a comment to T406424: Removed the FlaggedRevs extension on la.ws.

Mentioned in SAL (#wikimedia-operations) [2025-10-07T10:02:11Z] <ladsgroup@deploy2002> Finished scap sync-world: Backport for [[gerrit:1193564|Undeploy FlaggedRevs from lawikisource (T406424)]] (duration: 09m 34s)

Tue, Oct 7, 10:02 AM · Wikimedia-Site-requests, FlaggedRevs
Stashbot added a comment to T406424: Removed the FlaggedRevs extension on la.ws.

Mentioned in SAL (#wikimedia-operations) [2025-10-07T09:56:59Z] <ladsgroup@deploy2002> ladsgroup: Backport for [[gerrit:1193564|Undeploy FlaggedRevs from lawikisource (T406424)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Tue, Oct 7, 9:57 AM · Wikimedia-Site-requests, FlaggedRevs
Stashbot added a comment to T406424: Removed the FlaggedRevs extension on la.ws.

Mentioned in SAL (#wikimedia-operations) [2025-10-07T09:52:37Z] <ladsgroup@deploy2002> Started scap sync-world: Backport for [[gerrit:1193564|Undeploy FlaggedRevs from lawikisource (T406424)]]

Tue, Oct 7, 9:52 AM · Wikimedia-Site-requests, FlaggedRevs
gerritbot added a comment to T406424: Removed the FlaggedRevs extension on la.ws.

Change #1193564 merged by jenkins-bot:

[operations/mediawiki-config@master] Undeploy FlaggedRevs from lawikisource

https://gerrit.wikimedia.org/r/1193564

Tue, Oct 7, 9:52 AM · Wikimedia-Site-requests, FlaggedRevs
Ladsgroup added a comment to T406424: Removed the FlaggedRevs extension on la.ws.

We had cases that log without a formatter triggered fatals. If it's not causing that, then let's just do it. Worst case, we add a new formatter to WikimediaMessages.

Tue, Oct 7, 9:27 AM · Wikimedia-Site-requests, FlaggedRevs
Novem_Linguae added a comment to T406424: Removed the FlaggedRevs extension on la.ws.

Maybe we can just add that log message to https://www.mediawiki.org/wiki/Extension:WikimediaMessages

Tue, Oct 7, 5:07 AM · Wikimedia-Site-requests, FlaggedRevs
Pppery added a comment to T406424: Removed the FlaggedRevs extension on la.ws.

Do we need to do anything? They will end up appearing in the logs as something like "Alice performed unknown action 'review/review' on <page>", which is slightly awkward but not fundamentally broken.

Tue, Oct 7, 4:38 AM · Wikimedia-Site-requests, FlaggedRevs

Mon, Oct 6

Kizule added a comment to T406424: Removed the FlaggedRevs extension on la.ws.

Biggest point would be what to do with log rows. I thought we had something since FR has been undeployed from many wikis before but I can't find anything.

Mon, Oct 6, 7:50 PM · Wikimedia-Site-requests, FlaggedRevs
Jdlrobson-WMF moved T375231: ext-quick-survey-panel is showing up inside mw-fr-revision-details from Next to Bugs/small modifications on the QuickSurveys board.
Mon, Oct 6, 7:04 PM · FlaggedRevs
Dreamy_Jazz moved T397887: Indicate the FlaggedRevs revision status on Special:IPContributions from Needs review to Done on the Product Safety and Integrity (Sprint Apfel Strudel (Sep 29 - Oct 17)) board.

AFAICS this can be moved to Done? If not, feel free to move back

Mon, Oct 6, 2:09 PM · MW-1.45-notes (1.45.0-wmf.22; 2025-10-07), Product Safety and Integrity (Sprint Apfel Strudel (Sep 29 - Oct 17)), Temporary accounts, CheckUser, FlaggedRevs
Ladsgroup added a comment to T406424: Removed the FlaggedRevs extension on la.ws.

Biggest point would be what to do with log rows. I thought we had something since FR has been undeployed from many wikis before but I can't find anything.

Mon, Oct 6, 11:15 AM · Wikimedia-Site-requests, FlaggedRevs
Maintenance_bot removed a project from T397887: Indicate the FlaggedRevs revision status on Special:IPContributions: Patch-For-Review.
Mon, Oct 6, 10:31 AM · MW-1.45-notes (1.45.0-wmf.22; 2025-10-07), Product Safety and Integrity (Sprint Apfel Strudel (Sep 29 - Oct 17)), Temporary accounts, CheckUser, FlaggedRevs
ReleaseTaggerBot added a project to T397887: Indicate the FlaggedRevs revision status on Special:IPContributions: MW-1.45-notes (1.45.0-wmf.22; 2025-10-07).
Mon, Oct 6, 10:00 AM · MW-1.45-notes (1.45.0-wmf.22; 2025-10-07), Product Safety and Integrity (Sprint Apfel Strudel (Sep 29 - Oct 17)), Temporary accounts, CheckUser, FlaggedRevs
gerritbot added a comment to T397887: Indicate the FlaggedRevs revision status on Special:IPContributions.

Change #1192893 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] Support FlaggedRevs on Special:IPContributions

https://gerrit.wikimedia.org/r/1192893

Mon, Oct 6, 9:43 AM · MW-1.45-notes (1.45.0-wmf.22; 2025-10-07), Product Safety and Integrity (Sprint Apfel Strudel (Sep 29 - Oct 17)), Temporary accounts, CheckUser, FlaggedRevs

Sun, Oct 5

Tacsipacsi added a comment to T304935: Option to exclude unreviewed pages from Special:Random targets.

Actually, there is a page_random column exactly for this, page_id is not used for this purpose. The query MediaWiki core does by default is this:

Sun, Oct 5, 6:52 PM · FlaggedRevs
gerritbot added a project to T406424: Removed the FlaggedRevs extension on la.ws: Patch-For-Review.
Sun, Oct 5, 1:43 PM · Wikimedia-Site-requests, FlaggedRevs
gerritbot added a comment to T406424: Removed the FlaggedRevs extension on la.ws.

Change #1193564 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[operations/mediawiki-config@master] Undeploy FlaggedRevs from lawikisource

https://gerrit.wikimedia.org/r/1193564

Sun, Oct 5, 1:43 PM · Wikimedia-Site-requests, FlaggedRevs
Zache added a comment to T304935: Option to exclude unreviewed pages from Special:Random targets.

Technically in SQL finding random page could be done like this and retrying if RAND() results a page_id which doesn't return any article. Though I do not have any idea howto this would be implemented in medaiwiki level.

Sun, Oct 5, 12:12 PM · FlaggedRevs
Tacsipacsi added a comment to T304935: Option to exclude unreviewed pages from Special:Random targets.

@Bugreporter2 Do you have any idea how FlaggedRevs works? I already explained yesterday T193338#11243569 that what you propose just isn’t realistic, now you propose the same here. It still won’t work.

Sun, Oct 5, 11:28 AM · FlaggedRevs
Bugreporter2 added a comment to T304935: Option to exclude unreviewed pages from Special:Random targets.

You can do this by putting all reviewed pages into a category and then using [[Special:RandominCategory/]] in the sidebar.

Sun, Oct 5, 11:23 AM · FlaggedRevs
Aklapper added a comment to T406424: Removed the FlaggedRevs extension on la.ws.

@VIGNERON: In the future, please always follow https://meta.wikimedia.org/wiki/Requesting_wiki_configuration_changes when requesting such site configuration changes. Thanks!

Sun, Oct 5, 10:29 AM · Wikimedia-Site-requests, FlaggedRevs