Allows for article content management by "editor" and "reviewer" classes (Homepage)
Details
Yesterday
Looking closer at this the issue and chatting to @Catrope we would suggest using a Popover component instead:
https://doc.wikimedia.org/codex/main/components/demos/popover.html
What is the fiwiki page? (I don’t have access to Logstash.) The huwiki page has been deleted and undeleted between @Boro's recent edit and the previous one, so I think it suffered from T162778: If reviewed page was deleted and then undeleted, page is marked both as reviewed and unreviewed; maybe it’s the same on fiwiki?
It's still happening in a page in fiwiki: https://logstash.wikimedia.org/goto/59c61188ab8afa294c4b8db12e7cc4c2
There's no longer any hits in https://codesearch.wmcloud.org/search/?q=Xml%3A%3A&files=&excludeFiles=&repos=Extension%3AFlaggedRevs. I think we can close this.
I was able to review the file with a reviewed edit I made. So the ticket can be closed, I'm just not sure whether you want to keep it open to check the cause or not.
Sat, Oct 18
Change #1196536 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@master] Replace last use of Xml class with XmlSelect
Wed, Oct 15
Change #1196536 had a related patch set uploaded (by Jforrester; author: Jforrester):
[mediawiki/extensions/FlaggedRevs@master] Replace last use of Xml class with XmlSelect
This is almost completely done; there's only one hit left per https://codesearch.wmcloud.org/search/?q=Xml%3A%3A&files=&excludeFiles=&repos=Extension%3AFlaggedRevs — a call to Xml::listDropdown() in includes/frontend/specialpages/actions/Stabilization.php.
Tue, Oct 14
Mon, Oct 13
Fri, Oct 10
Thu, Oct 9
I tried several things just now (admin vs logged out editor doing the first edit, article vs redirect, regular title vs unicode title, various combinations of $wgFlaggedRevsOverride and $wgFlaggedRevsProtection, article vs category). Unable to reproduce in localhost.
Wed, Oct 8
According to the screenshots in the merged in ticket, mw-fr-reviewform (the thing in the footer) is showing as reviewed, and mw-indicator-indicator-fr-review-status (the little icon at the top right) is showing as unreviewed.
I think the description of the merged-in task was much better, with clear description of what “marked both as reviewed and non-reviewed” means, so I copy it here for reference:
Tue, Oct 7
Deployed. The logs look okay so far. I will drop the tables next week.
Mentioned in SAL (#wikimedia-operations) [2025-10-07T10:02:11Z] <ladsgroup@deploy2002> Finished scap sync-world: Backport for [[gerrit:1193564|Undeploy FlaggedRevs from lawikisource (T406424)]] (duration: 09m 34s)
Mentioned in SAL (#wikimedia-operations) [2025-10-07T09:56:59Z] <ladsgroup@deploy2002> ladsgroup: Backport for [[gerrit:1193564|Undeploy FlaggedRevs from lawikisource (T406424)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.
Mentioned in SAL (#wikimedia-operations) [2025-10-07T09:52:37Z] <ladsgroup@deploy2002> Started scap sync-world: Backport for [[gerrit:1193564|Undeploy FlaggedRevs from lawikisource (T406424)]]
Change #1193564 merged by jenkins-bot:
[operations/mediawiki-config@master] Undeploy FlaggedRevs from lawikisource
We had cases that log without a formatter triggered fatals. If it's not causing that, then let's just do it. Worst case, we add a new formatter to WikimediaMessages.
Maybe we can just add that log message to https://www.mediawiki.org/wiki/Extension:WikimediaMessages
Do we need to do anything? They will end up appearing in the logs as something like "Alice performed unknown action 'review/review' on <page>", which is slightly awkward but not fundamentally broken.
Mon, Oct 6
AFAICS this can be moved to Done? If not, feel free to move back
Biggest point would be what to do with log rows. I thought we had something since FR has been undeployed from many wikis before but I can't find anything.
Change #1192893 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@master] Support FlaggedRevs on Special:IPContributions
Sun, Oct 5
Actually, there is a page_random column exactly for this, page_id is not used for this purpose. The query MediaWiki core does by default is this:
Change #1193564 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):
[operations/mediawiki-config@master] Undeploy FlaggedRevs from lawikisource
Technically in SQL finding random page could be done like this and retrying if RAND() results a page_id which doesn't return any article. Though I do not have any idea howto this would be implemented in medaiwiki level.
@Bugreporter2 Do you have any idea how FlaggedRevs works? I already explained yesterday T193338#11243569 that what you propose just isn’t realistic, now you propose the same here. It still won’t work.
You can do this by putting all reviewed pages into a category and then using [[Special:RandominCategory/]] in the sidebar.
@VIGNERON: In the future, please always follow https://meta.wikimedia.org/wiki/Requesting_wiki_configuration_changes when requesting such site configuration changes. Thanks!