Skip to content

Raise more helpful errors in _dereference_path #3392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Raise more helpful errors in _dereference_path #3392

wants to merge 1 commit into from

Conversation

dstansby
Copy link
Contributor

See #3387 - this doesn't fix that bug, but it should at least raise a more helpful error message.

@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label Aug 20, 2025
d-v-b
d-v-b approved these changes Aug 20, 2025
View reviewed changes
Copy link
Contributor

@d-v-b d-v-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a later PR should add a docstring that explains what this function is supposed to do

@codecov Codecov
Copy link

codecov bot commented Aug 20, 2025

Codecov Report

❌ Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.62%. Comparing base (6a546d6) to head (44b442f).

Files with missing lines Patch % Lines
src/zarr/storage/_common.py 33.33% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3392      +/-   ##
==========================================
- Coverage   94.66%   94.62%   -0.05%     
==========================================
  Files          79       79              
  Lines        9444     9448       +4     
==========================================
  Hits         8940     8940              
- Misses        504      508       +4
Files with missing lines Coverage Δ
src/zarr/storage/_common.py 90.47% <33.33%> (-1.96%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-v-b d-v-b d-v-b approved these changes

Assignees
No one assigned
Labels
needs release notes Automatically applied to PRs which haven't added release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dstansby @d-v-b