Skip to content

fix(typescript-estree): revert #11232 (feat(typescript-estree): forbid invalid keys in EnumMember) #11493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2025

Conversation

kirkwaiblinger
Copy link
Member

@kirkwaiblinger kirkwaiblinger commented Aug 18, 2025

PR Checklist

Overview

This reverts commit d50a6b1.

This PR seems to have subtly broken CI. Let's revert and merge once we get to the bottom of that?

Note that #11488 is independent

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @kirkwaiblinger!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Aug 18, 2025

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit fc6ba7c
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/68a32070ec08d50008c27735
😎 Deploy Preview https://deploy-preview-11493--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 98 (🟢 up 6 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@kirkwaiblinger kirkwaiblinger changed the title Revert #11232 chore: revert #11232 Aug 18, 2025
Copy link

nx-cloud bot commented Aug 18, 2025

View your CI Pipeline Execution ↗ for commit fc6ba7c

Command Status Duration Result
nx run-many -t lint ✅ Succeeded 3m 23s View ↗
nx run-many -t typecheck ✅ Succeeded 2m 7s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 2s View ↗
nx test eslint-plugin --coverage=false ✅ Succeeded 5s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 3s View ↗
nx run types:build ✅ Succeeded 5s View ↗
nx run integration-tests:test ✅ Succeeded 3s View ↗
nx run generate-configs ✅ Succeeded 8s View ↗
Additional runs (27) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-08-18 12:51:28 UTC

@JoshuaKGoldberg JoshuaKGoldberg changed the title chore: revert #11232 fix: revert #11232 Aug 18, 2025
@JoshuaKGoldberg JoshuaKGoldberg changed the title fix: revert #11232 fix(typescript-estree): revert #11232 (feat(typescript-estree): forbid invalid keys in EnumMember) Aug 18, 2025
@JoshuaKGoldberg JoshuaKGoldberg merged commit 7648622 into typescript-eslint:main Aug 18, 2025
73 of 76 checks passed
@kirkwaiblinger kirkwaiblinger deleted the revert-11232 branch August 18, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants