Skip to content

chore: fix prettier typo blocking CI #11488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2025

Conversation

kirkwaiblinger
Copy link
Member

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @kirkwaiblinger!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Aug 16, 2025

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit aca1fb7
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/68a008ead6a3200008efea59
😎 Deploy Preview https://deploy-preview-11488--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 91 (🔴 down 1 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@kirkwaiblinger kirkwaiblinger enabled auto-merge (squash) August 16, 2025 04:28
Copy link

nx-cloud bot commented Aug 16, 2025

🤖 Nx Cloud AI Fix Eligible

An automatically generated fix could have helped fix failing tasks for this run, but Self-healing CI is disabled for this workspace. Visit workspace settings to enable it and get automatic fixes in future runs.

To disable these notifications, a workspace admin can disable them in workspace settings.


View your CI Pipeline Execution ↗ for commit aca1fb7

Command Status Duration Result
nx run-many -t lint ❌ Failed 3m 16s View ↗
nx run types:build ✅ Succeeded 4s View ↗

☁️ Nx Cloud last updated this comment at 2025-08-16 05:29:34 UTC

Copy link

codecov bot commented Aug 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.84%. Comparing base (19aa4d6) to head (aca1fb7).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11488      +/-   ##
==========================================
- Coverage   90.87%   90.84%   -0.03%     
==========================================
  Files         505      505              
  Lines       51121    51142      +21     
  Branches     8415     8413       -2     
==========================================
+ Hits        46455    46460       +5     
- Misses       4652     4668      +16     
  Partials       14       14              
Flag Coverage Δ
unittest 90.84% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bradzacher
Copy link
Member

Oops Ty

@bradzacher
Copy link
Member

@kirkwaiblinger looks like there's another CI error with linting. Idk why it's revealed by this change. Something funky with the nx caching?

Wanna fix it whilst you're here?

@kirkwaiblinger
Copy link
Member Author

Wanna fix it whilst you're here?

@bradzacher I tried looking into it but it didn't seem straightforward. Revert PR is up at #11493

@JoshuaKGoldberg JoshuaKGoldberg merged commit 07b8c8e into typescript-eslint:main Aug 18, 2025
117 of 119 checks passed
@kirkwaiblinger kirkwaiblinger deleted the prettier branch August 18, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants