prevent string pulling angle larger than 180 in dtNavMeshQuery::findStraightPath
#741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mauler125
added a commit
to Mauler125/r5sdk
that referenced
this pull request
Feb 28, 2025
Fix was taken from pull request recastnavigation/recastnavigation#741 but with a minor optimization to avoid decoding tile indices again after angle fixup is already pending.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit try to prevent inappropriate turning point by preventing the angle formed by
portaleft,portalApexandportalRightfrom becoming larger than 180 degree during the string pulling procedure.The variable
apexCrossTileis used to reduce unneccessary call of the methoddtTriArea2D.Detailed reason for this commit is discussed in #735.