Fix some compilation warnings #718
Conversation
8b242b4 to
624c744
Compare
|
I'm reporting the macos, msvc and premake errors reported by the CI to bmorel. |
02ec38e to
8c1eb0a
Compare
|
The remaining error happening with premake on Linux doesn't seem to be introduced by this branch: |
8c1eb0a to
3dc4e55
Compare
See this another PR for an attempt to fix that: |
| dtTileCacheAlloc& operator=( dtTileCacheAlloc const& ) = default; | ||
| dtTileCacheAlloc( dtTileCacheAlloc && ) = default; | ||
| dtTileCacheAlloc& operator=( dtTileCacheAlloc && ) = default; | ||
| #endif |
There was a problem hiding this comment.
Is this strictly necessary?
If it is, is there a version of this that would work for C++98 as well?
| { | ||
| dtAssert( std::numeric_limits<TO>::min() <= val && val <= std::numeric_limits<TO>::max() ); | ||
| return static_cast<TO>( val ); | ||
| } |
There was a problem hiding this comment.
This doesn't seem only applicable to "modern C++", so I'd be cool moving this to a DetourCommon.h
Also, I think a name like dtSafeNumericCast or dtCheckedNumericCast would be more appropriate here since this only works for numeric types, and it's checking that the value can be casted to the new type without losing information.
| { | ||
| rcAssert( std::numeric_limits<TO>::min() <= val && val <= std::numeric_limits<TO>::max() ); | ||
| return static_cast<TO>( val ); | ||
| } |
There was a problem hiding this comment.
Same thoughts here as the Detour version...
Some warning fixes by a contributor of Unvanquished, initially pulled from:
I modified the first commit commit of that branch to:
chmodchange to a dedicated commit,