setup docker to use uv for installation #11001
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
reviewed
Jul 8, 2025
| # Link the ia CLI binary into /usr/local/bin so that it shows up | ||
| # on the PATH. Do this instead of trying to modify the PATH, because | ||
| # that causes headaches with su, cron, etc. | ||
| COPY --from=ghcr.io/astral-sh/uv:latest /uv /uvx /bin/ |
There was a problem hiding this comment.
Looks like you're not using uvx, you could skip it.
|
Before: Pip install on my machine: With uv: Cut out 70s! |
|
Testing has been working smoothly, so I think we're good to go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing what it would take to get UV working for our docker setup. It's supposed to be a lot faster.
A nice byproduct is that it actually simplifies the dockerfiles a bit
Before
docker build --no-cache -f docker/Dockerfile.olbase -t openlibrary/olbase:latest .RUN python -m pip install --upgrade pip wheel && python -m pip install --default-timeout=100 -r requirements.txt 29.3s
docker compose buildRUN python -m pip install -r requirements_test.txt && python -m pip list --outdated 18.1s
RUN pip install $(grep -E 'webpy.git|web.py==|multipart==|Babel==' requirements.txt) 9.9s
Total time: 57.3 seconds
After
docker build --no-cache -f docker/Dockerfile.olbase -t openlibrary/olbase:latest .RUN uv pip install --upgrade wheel 1.0s
RUN uv pip install -r requirements.txt 10.6s
docker compose buildRUN uv pip install -r requirements_test.txt && uv pip list --outdated 12.3s
RUN uv pip install $(grep -E 'webpy.git|web.py==|multipart==|Babel==' requirements.txt) 0.2s
Total time: 24.1 seconds
Technical
Testing
Screenshot
Stakeholders