Skip to content

[generics][go1.19] Enable generics and remove overrides for generics #1387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 18, 2025

Conversation

grantnelson-wf
Copy link
Collaborator

I removed the experiment flag for generics, removed the generics check (that hopefully won't be needed anymore), and removed all the native overrides that were added as work arounds for the lack of generics.

I added an override for async/atomic.Pointer[T any] to use a simpler design since we don't have to worry about atomics and to avoid some issues with casing the unsafe.Pointer. Without this override one of the tests fails around a nil *byte which may be caused by #843 (didn't look into to it too deeply since it made more sense to just override atomic.Pointer even if it did work).

This is related to #1013 and #1270

@grantnelson-wf grantnelson-wf marked this pull request as ready for review August 15, 2025 21:40
@grantnelson-wf grantnelson-wf merged commit 1568908 into gopherjs:master Aug 18, 2025
10 checks passed
@grantnelson-wf grantnelson-wf deleted the enableGenerics1 branch August 18, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants