[generics][go1.19] Enable generics and remove overrides for generics #1387
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed the experiment flag for generics, removed the generics check (that hopefully won't be needed anymore), and removed all the native overrides that were added as work arounds for the lack of generics.
I added an override for
async/atomic.Pointer[T any]
to use a simpler design since we don't have to worry about atomics and to avoid some issues with casing theunsafe.Pointer
. Without this override one of the tests fails around anil *byte
which may be caused by #843 (didn't look into to it too deeply since it made more sense to just overrideatomic.Pointer
even if it did work).This is related to #1013 and #1270