gopherjs · grantnelson-wf · Aug 15, 2025 · Aug 13, 2025 · Aug 13, 2025 · Aug 13, 2025
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -115,8 +115,9 @@ jobs:
         run: go mod tidy && git diff --exit-code
       - name: Check natives build tags
         working-directory: ${{ env.GOPHERJS_PATH }}
-        # All those packages should have // +build js.
-        run: diff -u <(echo -n) <(go list ./compiler/natives/src/...)
+        run: |
+          echo "Any following packages have at least one file that is missing //go:build js"
+          diff -u <(echo -n) <(go list ./compiler/natives/src/...)
 
   go_tests:
     name: Go Tests

diff --git a/compiler/gopherjspkg/fs.go b/compiler/gopherjspkg/fs.go
@@ -1,8 +1,6 @@
 package gopherjspkg
 
-import (
-	"net/http"
-)
+import "net/http"
 
 // FS is a virtual filesystem that contains core GopherJS packages.
 var FS http.FileSystem

diff --git a/compiler/natives/src/bufio/bufio_test.go b/compiler/natives/src/bufio/bufio_test.go
@@ -1,5 +1,4 @@
 //go:build js
-// +build js
 
 package bufio_test
 

diff --git a/compiler/natives/src/bytes/bytes.go b/compiler/natives/src/bytes/bytes.go
@@ -1,5 +1,4 @@
 //go:build js
-// +build js
 
 package bytes
 

diff --git a/compiler/natives/src/bytes/bytes_test.go b/compiler/natives/src/bytes/bytes_test.go
@@ -1,11 +1,8 @@
 //go:build js
-// +build js
 
 package bytes_test
 
-import (
-	"testing"
-)
+import "testing"
 
 func dangerousSlice(t *testing.T) []byte {
 	t.Skip("dangerousSlice relies on syscall.Getpagesize, which GopherJS doesn't implement")

diff --git a/compiler/natives/src/compress/gzip/example_test.go b/compiler/natives/src/compress/gzip/example_test.go
@@ -1,11 +1,8 @@
 //go:build js && wasm
-// +build js,wasm
 
 package gzip_test
 
-import (
-	"fmt"
-)
+import "fmt"
 
 // The test relies on a local HTTP server, which is not supported under NodeJS.
 func Example_compressingReader() {

diff --git a/compiler/natives/src/crypto/elliptic/nistec.go b/compiler/natives/src/crypto/elliptic/nistec.go
@@ -1,5 +1,4 @@
 //go:build js
-// +build js
 
 package elliptic
 

diff --git a/compiler/natives/src/crypto/internal/boring/bbig/big.go b/compiler/natives/src/crypto/internal/boring/bbig/big.go
@@ -1,5 +1,4 @@
 //go:build js
-// +build js
 
 package bbig
 

diff --git a/compiler/natives/src/crypto/internal/boring/bcache/cache.go b/compiler/natives/src/crypto/internal/boring/bcache/cache.go
@@ -1,5 +1,4 @@
 //go:build js
-// +build js
 
 package bcache
 

diff --git a/compiler/natives/src/crypto/internal/boring/bcache/cache_test.go b/compiler/natives/src/crypto/internal/boring/bcache/cache_test.go
@@ -1,5 +1,4 @@
 //go:build js
-// +build js
 
 package bcache
 

diff --git a/compiler/natives/src/crypto/internal/boring/sig/sig.go b/compiler/natives/src/crypto/internal/boring/sig/sig.go
@@ -1,5 +1,4 @@
 //go:build js
-// +build js
 
 package sig
 

diff --git a/compiler/natives/src/crypto/internal/nistec/nistec_test.go b/compiler/natives/src/crypto/internal/nistec/nistec_test.go
@@ -1,5 +1,4 @@
 //go:build js
-// +build js
 
 package nistec_test
 

diff --git a/compiler/natives/src/crypto/internal/nistec/wrapper.go b/compiler/natives/src/crypto/internal/nistec/wrapper.go
@@ -1,5 +1,4 @@
 //go:build js
-// +build js
 
 package nistec
 

diff --git a/compiler/natives/src/crypto/internal/subtle/aliasing.go b/compiler/natives/src/crypto/internal/subtle/aliasing.go
@@ -1,5 +1,4 @@
 //go:build js
-// +build js
 
 package subtle
 

diff --git a/compiler/natives/src/crypto/rand/rand.go b/compiler/natives/src/crypto/rand/rand.go
@@ -1,5 +1,4 @@
 //go:build js
-// +build js
 
 package rand
 

diff --git a/compiler/natives/src/database/sql/driver/driver_test.go b/compiler/natives/src/database/sql/driver/driver_test.go
@@ -1,5 +1,4 @@
 //go:build js
-// +build js
 
 package driver
 
@@ -24,10 +23,10 @@ var valueConverterTests = []valueConverterTest{
 	{DefaultParameterConverter, (*int64)(nil), nil, ""},
 	{DefaultParameterConverter, &answer, answer, ""},
 	{DefaultParameterConverter, &now, now, ""},
-	//{DefaultParameterConverter, i(9), int64(9), ""}, // TODO: Fix.
+	//{DefaultParameterConverter, i(9), int64(9), ""}, // TODO: Fix. Errors with `driver.defaultConverter(driver.i(9)) = 9 (driver.i); want 9 (int64)`
 	{DefaultParameterConverter, f(0.1), float64(0.1), ""},
 	{DefaultParameterConverter, b(true), true, ""},
-	//{DefaultParameterConverter, bs{1}, []byte{1}, ""}, // TODO: Fix.
+	//{DefaultParameterConverter, bs{1}, []byte{1}, ""}, // TODO: Fix. Errors with `driver.defaultConverter(driver.bs([1])) = [1] (driver.bs); want [1] ([]uint8)`
 	{DefaultParameterConverter, s("a"), "a", ""},
 	{DefaultParameterConverter, is{1}, nil, "unsupported type driver.is, a slice of int"},
 }
diff --git a/compiler/natives/src/debug/pe/symbol.go b/compiler/natives/src/debug/pe/symbol.go
@@ -1,5 +1,4 @@
 //go:build js
-// +build js
 
 package pe
 

diff --git a/compiler/natives/src/embed/embed.go b/compiler/natives/src/embed/embed.go
@@ -1,5 +1,4 @@
 //go:build js
-// +build js
 
 package embed
 

diff --git a/compiler/natives/src/encoding/gob/gob_test.go b/compiler/natives/src/encoding/gob/gob_test.go
@@ -1,5 +1,4 @@
 //go:build js
-// +build js
 
 package gob
 
@@ -105,3 +104,7 @@ func TestTypeRace(t *testing.T) {
 	// cannot succeed when nosync is used.
 	t.Skip("using nosync")
 }
+
+func TestCountDecodeMallocs(t *testing.T) {
+	t.Skip("testing.AllocsPerRun not supported in GopherJS")
+}
diff --git a/compiler/natives/src/encoding/json/stream_test.go b/compiler/natives/src/encoding/json/stream_test.go
@@ -1,5 +1,4 @@
 //go:build js
-// +build js
 
 package json
 

diff --git a/compiler/natives/src/fmt/fmt_test.go b/compiler/natives/src/fmt/fmt_test.go
@@ -1,5 +1,4 @@
 //go:build js
-// +build js
 
 package fmt_test
 

diff --git a/compiler/natives/src/go/parser/parser_test.go b/compiler/natives/src/go/parser/parser_test.go
@@ -2,9 +2,7 @@
 
 package parser
 
-import (
-	"testing"
-)
+import "testing"
 
 func TestParseDepthLimit(t *testing.T) {
 	t.Skip("causes call stack exhaustion on js/ecmascript")

diff --git a/compiler/natives/src/go/token/position.go b/compiler/natives/src/go/token/position.go
@@ -1,5 +1,4 @@
 //go:build js
-// +build js
 
 package token
 

diff --git a/compiler/natives/src/go/token/token_test.go b/compiler/natives/src/go/token/token_test.go
@@ -1,12 +1,9 @@
 //go:build js
-// +build js
 
 package token
 
-import (
-	"testing"
-)
+import "testing"
 
 func TestFileSetRace(t *testing.T) {
-	t.Skip()
+	t.Skip("Fails with: WaitGroup counter not zero")
 }
diff --git a/compiler/natives/src/golang.org/x/crypto/internal/alias/alias.go b/compiler/natives/src/golang.org/x/crypto/internal/alias/alias.go
@@ -1,5 +1,4 @@
 //go:build js
-// +build js
 
 package alias
 

diff --git a/compiler/natives/src/golang.org/x/crypto/internal/subtle/aliasing.go b/compiler/natives/src/golang.org/x/crypto/internal/subtle/aliasing.go
@@ -1,5 +1,4 @@
 //go:build js
-// +build js
 
 package subtle
 

diff --git a/compiler/natives/src/hash/maphash/maphash.go b/compiler/natives/src/hash/maphash/maphash.go
@@ -1,11 +1,8 @@
 //go:build js
-// +build js
 
 package maphash
 
-import (
-	_ "unsafe" // for linkname
-)
+import _ "unsafe" // for linkname
 
 // hashkey is similar how it is defined in runtime/alg.go for Go 1.19
 // to be used in hash{32,64}.go to seed the hash function as part of

diff --git a/compiler/natives/src/hash/maphash/maphash_test.go b/compiler/natives/src/hash/maphash/maphash_test.go
@@ -0,0 +1,53 @@
+//go:build js
+
+package maphash
+
+import "testing"
+
+//gopherjs:keep-original
+func TestSmhasherSmallKeys(t *testing.T) {
+	if !testing.Short() {
+		t.Skip("Causes a heap overflow in GopherJS when not --short")
+		// This test adds a lot of uint64 hashes into a map,
+		// (16,843,008 for long tests, 65,792 for short tests)
+		// inside `(s *hashSet) add(h uint64)` with `s.m[h] = struct{}{}`.
+		// This is to check the number of collisions in the hash function.
+	}
+	_gopherjs_original_TestSmhasherSmallKeys(t)
+}
+
+//gopherjs:keep-original
+func TestSmhasherZeros(t *testing.T) {
+	if !testing.Short() {
+		t.Skip("Too slow when not --short")
+		// This test creates a byte slice with 262,144 bytes for long tests
+		// and 1,024 for short tests filled by defualt with zeroes.
+		// Then it adds [:1], [:2], and so on upto the full slice.
+	}
+	_gopherjs_original_TestSmhasherZeros(t)
+}
+
+func TestSmhasherTwoNonzero(t *testing.T) {
+	// The original skips if `runtime.GOARCH == "wasm"` which means we should skip too.
+	t.Skip("Too slow on wasm and JS")
+}
+
+func TestSmhasherSparse(t *testing.T) {
+	// The original skips if `runtime.GOARCH == "wasm"` which means we should skip too.
+	t.Skip("Too slow on wasm and JS")
+}
+
+func TestSmhasherPermutation(t *testing.T) {
+	// The original skips if `runtime.GOARCH == "wasm"` which means we should skip too.
+	t.Skip("Too slow on wasm and JS")
+}
+
+func TestSmhasherAvalanche(t *testing.T) {
+	// The original skips if `runtime.GOARCH == "wasm"` which means we should skip too.
+	t.Skip("Too slow on wasm and JS")
+}
+
+func TestSmhasherWindowed(t *testing.T) {
+	// The original skips if `runtime.GOARCH == "wasm"` which means we should skip too.
+	t.Skip("Too slow on wasm and JS")
+}
diff --git a/compiler/natives/src/internal/bytealg/bytealg.go b/compiler/natives/src/internal/bytealg/bytealg.go
@@ -1,5 +1,4 @@
 //go:build js
-// +build js
 
 package bytealg
 

diff --git a/compiler/natives/src/internal/cpu/cpu.go b/compiler/natives/src/internal/cpu/cpu.go
@@ -1,5 +1,4 @@
 //go:build js
-// +build js
 
 package cpu
 

diff --git a/compiler/natives/src/internal/fmtsort/fmtsort_test.go b/compiler/natives/src/internal/fmtsort/fmtsort_test.go
@@ -1,5 +1,4 @@
 //go:build js
-// +build js
 
 package fmtsort_test
 

diff --git a/compiler/natives/src/internal/poll/semaphore.go b/compiler/natives/src/internal/poll/semaphore.go
@@ -1,11 +1,8 @@
 //go:build js
-// +build js
 
 package poll
 
-import (
-	_ "unsafe" // For go:linkname
-)
+import _ "unsafe" // For go:linkname
 
 //go:linkname runtime_Semacquire sync.runtime_Semacquire
 func runtime_Semacquire(s *uint32)

diff --git a/compiler/natives/src/internal/reflectlite/all_test.go b/compiler/natives/src/internal/reflectlite/all_test.go
@@ -1,27 +1,7 @@
 //go:build js
-// +build js
 
 package reflectlite_test
 
-import (
-	"testing"
-
-	. "internal/reflectlite"
-)
-
-func TestTypes(t *testing.T) {
-	for i, tt := range typeTests {
-		if i == 30 {
-			continue
-		}
-		testReflectType(t, i, Field(ValueOf(tt.i), 0).Type(), tt.s)
-	}
-}
-
-func TestNameBytesAreAligned(t *testing.T) {
-	t.Skip("TestNameBytesAreAligned")
-}
-
 // `A` is used with `B[T any]` and is otherwise not needed.
 //
 //gopherjs:purge for go1.19 without generics

diff --git a/compiler/natives/src/internal/reflectlite/export_test.go b/compiler/natives/src/internal/reflectlite/export_test.go
@@ -1,11 +1,8 @@
 //go:build js
-// +build js
 
 package reflectlite
 
-import (
-	"unsafe"
-)
+import "unsafe"
 
 // Field returns the i'th field of the struct v.
 // It panics if v's Kind is not Struct or i is out of range.

diff --git a/compiler/natives/src/internal/reflectlite/reflect_mirror_test.go b/compiler/natives/src/internal/reflectlite/reflect_mirror_test.go
diff --git a/compiler/natives/src/internal/reflectlite/reflectlite.go b/compiler/natives/src/internal/reflectlite/reflectlite.go
@@ -1,5 +1,4 @@
 //go:build js
-// +build js
 
 package reflectlite
 

diff --git a/compiler/natives/src/internal/reflectlite/swapper.go b/compiler/natives/src/internal/reflectlite/swapper.go
@@ -1,5 +1,4 @@
 //go:build js
-// +build js
 
 package reflectlite
 

diff --git a/compiler/natives/src/internal/reflectlite/type.go b/compiler/natives/src/internal/reflectlite/type.go
@@ -1,5 +1,4 @@
 //go:build js
-// +build js
 
 package reflectlite
 

diff --git a/compiler/natives/src/internal/reflectlite/utils.go b/compiler/natives/src/internal/reflectlite/utils.go
@@ -1,11 +1,8 @@
 //go:build js
-// +build js
 
 package reflectlite
 
-import (
-	"unsafe"
-)
+import "unsafe"
 
 type ChanDir int