Skip to content

Update go1.19 native overrides #1386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 15, 2025

Conversation

grantnelson-wf
Copy link
Collaborator

In preparation for go1.19 with generics I did some preliminary cleanup of the native overrides:

  • I removed the old build tags, // +build. As it says in the go cmd docs that type of build tags were replaced with //go:build tags after go1.16. This will not affect reading files and // +build will still work.
  • I formatted the imports (only caused single imports to inline).
  • I went through the existing packages looking for tests which no longer fail or no longer exist in go1.19. I did not remove tests that required generics to function.
  • I ran most of the packages without --short and added some overrides that were missing. There was a lot of issues in net/... and in runtime/... that I didn't fix because they were in the .std_test_pkg_exclusions and I didn't want to determine which packages in that, if any, we wanted to start supporting.
  • For some of the tests which didn't specify why they were being skipped, I added a reason.

@grantnelson-wf grantnelson-wf self-assigned this Aug 13, 2025
@grantnelson-wf grantnelson-wf marked this pull request as ready for review August 13, 2025 21:18
@grantnelson-wf grantnelson-wf merged commit 5229e7f into gopherjs:master Aug 15, 2025
10 checks passed
@grantnelson-wf grantnelson-wf deleted the update119Overrides branch August 15, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants