This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fixed the nullability annotation on codec writeValue:
#35814
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmagman
approved these changes
Aug 31, 2022
There was a problem hiding this comment.
engine/shell/platform/darwin/common/framework/Source/FlutterStandardCodec.mm
Lines 273 to 275 in 2962099
LGTM
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 1, 2022
zanderso
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 1, 2022
…110796) * f30fed5ab Ignore all translations in Matrix::TransformDirection (flutter/engine#35854) * d8928a0b6 [Impeller] More aggressively downscale gaussian blur textures (flutter/engine#35853) * 5454c09a0 Roll Fuchsia Mac SDK from sgXD5SyRPOxGjWV4q... to VCkCQ9VaBkOXaOnQU... (flutter/engine#35858) * 4ef0eb243 Roll Skia from d505b9445bf6 to 74d7dcaf7a4e (1 revision) (flutter/engine#35857) * 5cab38584 Do frustum culling after the MSAA backdrop draw (flutter/engine#35847) * 4e6bb5da5 Roll Skia from 74d7dcaf7a4e to ca89d2781f78 (1 revision) (flutter/engine#35859) * 5dc718f92 Roll Skia from ca89d2781f78 to 8c7e99e0546e (2 revisions) (flutter/engine#35860) * c3a956050 Roll Skia from 8c7e99e0546e to defbe6b80d7b (1 revision) (flutter/engine#35861) * 1f7fe40d8 Roll Skia from defbe6b80d7b to d8a45111ba9a (1 revision) (flutter/engine#35862) * f74d2439e Add function restoreToCount to Canvas. (flutter/engine#35798) * 152228e27 Roll Skia from d8a45111ba9a to 97f1748bbfc0 (1 revision) (flutter/engine#35863) * 08394d74c Fixed the nullability annotation on codec `writeValue:` (flutter/engine#35814) * 185f4f595 Revert "roll CanvasKit to 0.36.1 (attempt 2) (#35839)" (flutter/engine#35864)
8 tasks
|
I thought we could get away with this not being a breaking change since I didn't see any of our tests failing. It has affected google customer tests though so we'll have to revert this and land it with manual roll. see also b/244680558 |
gaaclarke
added a commit
to gaaclarke/engine
that referenced
this pull request
Sep 2, 2022
…ter#35814)" This reverts commit 08394d7.
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.