use pub run for create test and remove [INFO] logs #35839
Conversation
| @@ -240,7 +240,8 @@ Future<void> _runToolTests() async { | |||
| File(path.join(flutterRoot, 'bin', 'cache', 'flutter_tools.snapshot')).deleteSync(); | |||
| File(path.join(flutterRoot, 'bin', 'cache', 'flutter_tools.stamp')).deleteSync(); | |||
| } | |||
| if (noUseBuildRunner) { | |||
| // reduce overhead of build_runner in the create case. | |||
| if (noUseBuildRunner || Platform.environment['SUBSHARD'] == 'create') { | |||
There was a problem hiding this comment.
We need to update the logic at https://github.com/flutter/flutter/pull/35839/files#diff-a9d73960c607f511d218217af489e4d5R587 and following for this
There was a problem hiding this comment.
Not quite sure what you mean
There was a problem hiding this comment.
There's logic in there to check the subshard and run the right subset of tests using tags. I don't think it matches the logic in the build runner variant of the method.
There was a problem hiding this comment.
Oh duh, got it my bad
|
Thanks - I meant to do this and forgot |
|
Is commands/create_test.dart the only test that uses the 'create' tag? I can just pass the test file directly to avoid loading everything else |
|
I think so but would have to double check. Actually for this one we probably don't want to use tags so test doesn't have to scan the whole thing |
|
Updated to use the testfile |
|
LGTM |
Description
Since we're only running one (or two?) test files the overhead of pre-compilation is not worth it. This will also cut down on the logspam in this particular case.