Skip to content

add plugin tracing spans #20722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add plugin tracing spans #20722

wants to merge 1 commit into from
+15 −0

Conversation

atlv24
Copy link
Contributor

@atlv24 atlv24 commented Aug 23, 2025

Objective

  • easily diagnose startup performance issues

Solution

  • add plugin tracing spans

Testing

  • i have not been able to get any tracing to work in any of bevy. idk if this code works, but it looks like it should. is tracing broken or do i have a setup issue?

@atlv24 atlv24 added S-Needs-Review Needs reviewer attention (from anyone!) to move forward C-Performance A change motivated by improving speed, memory usage or compile times labels Aug 23, 2025
@alice-i-cecile alice-i-cecile added A-App Bevy apps and plugins S-Needs-Testing Testing must be done before this is safe to merge labels Aug 23, 2025
hymm
hymm reviewed Aug 24, 2025
View reviewed changes
Copy link
Contributor

@hymm hymm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Works for me. I think we should add an overarching span for each phase too. So one more span for each of the build, finish and cleanup phases.

@james7132 james7132 removed the S-Needs-Testing Testing must be done before this is safe to merge label Aug 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james7132 james7132 james7132 approved these changes

+1 more reviewer

@hymm hymm hymm left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
A-App Bevy apps and plugins C-Performance A change motivated by improving speed, memory usage or compile times S-Needs-Review Needs reviewer attention (from anyone!) to move forward
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@atlv24 @hymm @james7132 @alice-i-cecile