Skip to content

Drop Ruby 3.0 compatibility #8489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Drop Ruby 3.0 compatibility #8489

merged 1 commit into from
Oct 1, 2024

Conversation

tagliala
Copy link
Contributor

@tagliala tagliala commented Sep 30, 2024

Also improve test app generator flags:

  • Add brakeman, ci, and rubocop skips
  • Remove listen, spring, turbolinks, and webpack-install skips,
    dropped in Rails 7.0
  • Sort remaining skips

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.11%. Comparing base (fc5bcdd) to head (7b90053).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8489   +/-   ##
=======================================
  Coverage   99.11%   99.11%           
=======================================
  Files         141      141           
  Lines        4076     4076           
=======================================
  Hits         4040     4040           
  Misses         36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tagliala tagliala marked this pull request as draft September 30, 2024 14:37
@tagliala tagliala force-pushed the feature/drop-ruby-30 branch 2 times, most recently from 908cf8c to 5a7389b Compare September 30, 2024 20:50
@tagliala tagliala changed the title Drop Ruby 3.0 Drop Ruby 3.0 compatibility Sep 30, 2024
@tagliala tagliala force-pushed the feature/drop-ruby-30 branch 3 times, most recently from 7c6e519 to 87a718b Compare September 30, 2024 21:14
Also improve test app generator flags:
- Add `brakeman`, `ci`, and `rubocop` skips
- Remove `listen`, `spring`, `turbolinks`, and `webpack-install` skips,
  dropped in Rails 7.0
- Sort remaining skips
@tagliala tagliala force-pushed the feature/drop-ruby-30 branch from 87a718b to 7b90053 Compare September 30, 2024 21:15
@tagliala tagliala marked this pull request as ready for review September 30, 2024 21:19
Comment on lines +403 to +406
sqlite3 (2.1.0-aarch64-linux-gnu)
sqlite3 (2.1.0-arm64-darwin)
sqlite3 (2.1.0-x86_64-darwin)
sqlite3 (2.1.0-x86_64-linux-gnu)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

require Ruby 3.1

Copy link
Member

@javierjulio javierjulio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tagliala tagliala merged commit 2bdb590 into master Oct 1, 2024
23 checks passed
@tagliala tagliala deleted the feature/drop-ruby-30 branch October 1, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants