Minor development updates #8488
Conversation
|
https://github.com/activeadmin/activeadmin/actions/runs/11071311136/job/30762881938#step:5:1278
This is unfortunate |
| @@ -32,7 +32,7 @@ jobs: | |||
| include: | |||
| - ruby: '3.0' | |||
| os: ubuntu-latest | |||
| rails: rails_71 | |||
| rails: rails_70 | |||
There was a problem hiding this comment.
If this solution to #8488 (comment) is acceptable, I will change the required actions in settings to allow the branch to be merged without skipping branch rules
There was a problem hiding this comment.
I'm fine with dropping Ruby 3.0 from CI now. If that helps here and you are ok with it, let's do that.
There was a problem hiding this comment.
I would not do that if 3.0 is supported, I'm afraid of unintended breaking changes at patch level, in example by using 3.1 only syntax (like Array#intersect?)
This happened several times in the past, a couple of the most recent breaking changes at patch level that I remember are
- Keep testing against 2.7 and 3.0 in version 5.0.x to avoid breaking changes at patch level sidekiq-scheduler/sidekiq-scheduler#477
- Factory Bot 6.4.5: Syntax error with Ruby < 2.7, but the ruby gem requirement is still
>= 2.5.0thoughtbot/factory_bot#1614
Please let me know what you think
There was a problem hiding this comment.
Well I figure we would bump the minimum required version anyway. I recall we've done that each time we've dropped an old EOL version. You are welcome to open that PR to drop Ruby 3.0 now if you want.
There was a problem hiding this comment.
As a reference, here it is another breaking change introduced in a patch level release because of the shorthand syntax (>= 3.1)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8488 +/- ##
=======================================
Coverage 99.11% 99.11%
=======================================
Files 141 141
Lines 4069 4069
=======================================
Hits 4033 4033
Misses 36 36 ☔ View full report in Codecov by Sentry. |
- Sort skips - Skip `rubocop`, `brakeman`, and `ci`
Will test the minimum required Ruby version against the minimum required Rails version to allow Rails 7.1 to use sqlite 2.1 ``` sqlite3-2.1.0-x86_64-linux-gnu requires ruby version < 3.4.dev, >= 3.1, which is incompatible with the current version, 3.0.7 ```
4462f06 to
18d8fcf
Compare
|
Superseded by #8489 |
Uh oh!
There was an error while loading. Please reload this page.