-
Notifications
You must be signed in to change notification settings - Fork 15
Replace all Apple glyph names with their HTML code #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3e83b9b
to
cebb3d6
Compare
I haven't found a way to have glyphs shown between backticks so I decided to bold them all. Let me know what you all think. |
Thanks @codedbypm ! 🎉 💯 I think this looks great. The only thing is that the section "Quick reference for Apple glyphs HTML codes" is very prominent, which feels a bit awkward. What if we put that at the very bottom of the page, or in its own page? EDIT: Oh actually, what about putting the HTML code cheat sheet in the contributing guide? |
I share your same opinion about that reference. EDIT: I like the idea of putting it in the CONTRIBUTING.md |
totally agree!
Let's go with this! Let's also add a note to the steps: "Please use Apple Glyphs when mentioning keyboard shortcuts." 😊 |
1d7a0b9
to
c530695
Compare
Please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @codedbypm ! 💯
In this PR: