-
Notifications
You must be signed in to change notification settings - Fork 15
Use Apple glyphs for Cmd, Alt, Ctrl and Shift #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks @codedbypm ! 💯 🎉 I definitely like this idea. Some concerns:
Maybe we use a hybrid approach, like this:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
going to formally "request changes" as we discuss 😊
Correct. I also noticed that when editing the markdown, they are all a tad small, and shift is the one where the issue is more evident. Here you can see the rendered page. They are visually better than in the raw markdown
Yeah, HTML feels more future proof. It renders always properly (but not when text is in between backticks!) and allows for easier copy-paste or search-replace operations. For that, I would propose to add a commented-out legend at the beginning of the file to use as a quick reference for the random github user that passes by and wants to contribute and needs those glyphs.
mmm let me think about this last one |
lol, oops I forgot about that. 😊
Sounds good. And I'm sorry about the conflicts! 😄 Edit: Oh one other thing, it looks like putting a space between characters also helps with readability. For example: ⌘ J vs ⌘J |
I updated the PR |
Has content been moved around recently? This PR has now merge conflicts that are not fixable by just one tap. And after spending the whole day at work, coding, reviewing, fixing conflicts, etc, the last thing I want in the eve is to have more conflicts to solve :D And from such a simple repo, I would definitely not expect conflicts |
Yes. We renamed "Shortcuts" to "Keyboard Shortcuts" and re-alphabetized the list.
Totally understandable. 🤗 That's why we call it open sores software. 😆 It might be easier to just re-branch off off |
@codedbypm I sent you an invite to join the org, which means you won't have to work off of a fork anymore, and should make development easier. In the case that you do not want to move forward, I've opened #19 to track this so that someone else could carry this forward if they wish. Again -- sorry about the conflicts! I know it's frustrating. |
No worries. That night was the end of a very long coding day :D My complaint had only the goal to make things better and smoother for whoever comes next. |
Closing this in favor of #20 |
I think #16 could help with this. 😊 |
In this PR: