This tag is used to group security bugs by their general classification. These bugs allow an attacker to run JavaScript in another user's browser (Cross-site Scripting / XSS). See OWASP Top 10 2017 - A7
Parent project: Security-Team
This tag is used to group security bugs by their general classification. These bugs allow an attacker to run JavaScript in another user's browser (Cross-site Scripting / XSS). See OWASP Top 10 2017 - A7
Parent project: Security-Team
I think we can skip QA on this given that it's not happened in around a month.
Closing this as there seems to be no other action needed on our part. @jrbs please re-open if there's a problem.
All three XSSs appear to be fixed, so I don't think there's anything left to do here
Is there more to do here, or can this be closed?
Thanks for sorting this one out. I will resolve it since there are no more actionable items.
Change #1175227 merged by jenkins-bot:
[mediawiki/skins/BlueSky@REL1_43] SECURITY: Properly escape system messages when creating links
Change #1175226 merged by jenkins-bot:
[mediawiki/skins/BlueSky@REL1_44] SECURITY: Properly escape system messages when creating links
Change #1175228 merged by jenkins-bot:
[mediawiki/skins/BlueSky@REL1_39] SECURITY: Properly escape system messages when creating links
Change #1175210 merged by jenkins-bot:
[mediawiki/skins/BlueSky@master] SECURITY: Properly escape system messages when creating links
Change #1175228 had a related patch set uploaded (by SomeRandomDeveloper; author: SomeRandomDeveloper):
[mediawiki/skins/BlueSky@REL1_39] SECURITY: Properly escape system messages when creating links
Change #1175227 had a related patch set uploaded (by SomeRandomDeveloper; author: SomeRandomDeveloper):
[mediawiki/skins/BlueSky@REL1_43] SECURITY: Properly escape system messages when creating links
Change #1175226 had a related patch set uploaded (by SomeRandomDeveloper; author: SomeRandomDeveloper):
[mediawiki/skins/BlueSky@REL1_44] SECURITY: Properly escape system messages when creating links
Change #1175210 had a related patch set uploaded (by SomeRandomDeveloper; author: SomeRandomDeveloper):
[mediawiki/skins/BlueSky@master] SECURITY: Properly escape system messages when creating links
Patch:
I was working on T279315: Replace usages of Linker::link() and Linker::linkKnown() in BlueSky skin, and accidentally fixed some of these vulnerabilities in a public non-security patch (https://gerrit.wikimedia.org/r/c/mediawiki/skins/BlueSky/+/1175210) before even realizing that there were i18n XSSs in the skin, so I'm going to update that patch so it fixes all vulnerabilities and mentions this task.
No CVE or security release will be necessary here, as this issue only lived within Wikimedia's production configuration.
In T400501#11041416, @sbassett wrote:I think we can probably just open up this bug now? This shouldn't ever be included within a security release.
I think we can probably just open up this bug now? This shouldn't ever be included within a security release.
Looks like I forgot to mention the task in the commit message. For those reading this task after it was made public, this was uploaded to gerrit and merged: https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/1173481
Note: the plan here is to do a very quick config deploy via a public gerrit patch.
In T400501#11036460, @SomeRandomDeveloper wrote:
Change #1163476 merged by jenkins-bot:
[utfnormal@master] Replace isolated combining characters
Skin::makeInternalOrExternalUrl() is commonly used in MW code to prevent this (a 'javascript:' URL will instead be treated as an internal link to a wiki page by that title, instead of an external link to a full URL).