zphysics: support for shape serialization #731
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add StreamOut and StreamIn interfaces - Add implementations of StreamOut / StreamIn that use AnyWriter / AnyReader - Add Shape::saveBinaryState and Shape::RestoreFromBinaryState
b49d86c to
3c81004
Compare
|
Looks good to me. |
|
Cool, I'll hold off until the migration and PR there, as I have some more changes for this patch - it turns out I do need to use SaveWithChildren / RestoreWithChildren in my use case so I need to add those as well. |
|
Moved here zig-gamedev/zphysics#1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are some proposed changes to add support for binary serialization of shapes.
StreamOutandStreamIninterfacesStreamOut/StreamInthat useAnyWriter/AnyReaderShape::saveBinaryStateandShape::RestoreFromBinaryStateOpening this as a draft as I may be adding support for
SaveMaterialStateandSaveSubShapeStatedepending on if my use case requires it or not. I'm avoiding it for now as the map data structures may be tricky to easily map between C/C++.