-
-
Notifications
You must be signed in to change notification settings - Fork 178
[Breaking] Fold zwin32, zxaudio2 and zd3d12 into zwindows #685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Will zxaudio2 and z3d12 be optional submodules to zwindows, or how will it work? |
Yes they could be zig modules provided by zwindows dependency. I will update the PR description later to explain better. |
939d3b9
to
870cc99
Compare
Just in case you're not aware, there's a proposal to remove usingnamespace, so it may be worth avoiding. Seems like it could go either way at the moment. |
I've removed the PR description has been updated to reflect the changes. |
Any objections to me merging this as is? |
These libs are almost always used together. Why not just put them together into an uber windows sdk Zig package?
Checklist
Changes to build.zig usage:
Other changes:
w32.zig
renamed tobindings/windows.zig
as this is now serving as an extension ofstd.os.windows
(parts of which will be upstreamed or deprecated).zd3d12_enable_d2d
build option deleted. The user can just not call the d2d fns if they don't want it.zd3d12_upload_heap_capacity
build option deleted. Now capacity can be set at runtime when callingzd3d12.GraphicsContext.init
who's function signature has been changed to take an args struct.