-
-
Notifications
You must be signed in to change notification settings - Fork 356
Add default value to init_array config param. Update docstring. #3391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kgabor
wants to merge
1
commit into
zarr-developers:main
Choose a base branch
from
kgabor:config_param_3222
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9c8d51f
to
ddd3827
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3391 +/- ##
=======================================
Coverage 94.69% 94.69%
=======================================
Files 79 79
Lines 9520 9520
=======================================
Hits 9015 9015
Misses 505 505
🚀 New features to boost your workflow:
|
ddd3827
to
d9df4f6
Compare
* Add default value to init_array config param. * Update docstring. * Add changelog entry. * Fix type casting typo.
d9df4f6
to
38fe656
Compare
d-v-b
reviewed
Aug 23, 2025
@@ -4525,7 +4525,7 @@ async def init_array( | |||
overwrite : bool, default False | |||
Whether to overwrite an array with the same name in the store, if one exists. | |||
config : ArrayConfigLike or None, optional |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
config : ArrayConfigLike or None, optional | |
config : ArrayConfigLike or None, default=None |
d-v-b
reviewed
Aug 23, 2025
@@ -4525,7 +4525,7 @@ async def init_array( | |||
overwrite : bool, default False | |||
Whether to overwrite an array with the same name in the store, if one exists. | |||
config : ArrayConfigLike or None, optional | |||
Configuration for this array. | |||
Configuration for this array (default is None). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
Configuration for this array (default is None). | |
Configuration for this array. If ``None``, the default array runtime configuration will be used. This default | |
is stored in the global configuration object. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make config param optional in
init_array
. Closes #3222TODO:
docs/user-guide/*.rst
changes/