Skip to content

chore/remove chunk coords #3374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 18, 2025
Merged

chore/remove chunk coords #3374

merged 5 commits into from
Aug 18, 2025

Conversation

d-v-b
Copy link
Contributor

@d-v-b d-v-b commented Aug 13, 2025 •
edited
Loading

replaces all occurrences usage of ChunkCoords with tuple[int, ...]

I do keep the ChunkCoords definition in zarr.core.common in case someone was using it, since we do have people using our private API in the wild. Happy to remove this if people think it's safe.

closes #3373

@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label Aug 13, 2025
d-v-b
d-v-b commented Aug 13, 2025
View reviewed changes
src/zarr/core/common.py
ShapeLike = tuple[int, ...] | int
ChunkCoords = tuple[int, ...]
ChunkCoordsLike = Iterable[int]
ShapeLike = Iterable[int] | int
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note this change, which better matches the intent of ShapeLike.

@github-actions github-actions bot removed the needs release notes Automatically applied to PRs which haven't added release notes label Aug 13, 2025
@d-v-b d-v-b requested a review from a team August 13, 2025 12:46
@d-v-b d-v-b enabled auto-merge (squash) August 18, 2025 15:50
@codecov Codecov
Copy link

codecov bot commented Aug 18, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.55%. Comparing base (1a4aa5b) to head (f8d8d2d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3374      +/-   ##
==========================================
- Coverage   94.55%   94.55%   -0.01%     
==========================================
  Files          79       79              
  Lines        9448     9447       -1     
==========================================
- Hits         8934     8933       -1     
  Misses        514      514
Files with missing lines Coverage Δ
src/zarr/abc/codec.py 95.06% <100.00%> (ø)
src/zarr/api/asynchronous.py 87.62% <100.00%> (ø)
src/zarr/api/synchronous.py 92.95% <100.00%> (ø)
src/zarr/codecs/sharding.py 94.47% <100.00%> (ø)
src/zarr/codecs/transpose.py 89.47% <100.00%> (ø)
src/zarr/core/array.py 97.10% <100.00%> (ø)
src/zarr/core/array_spec.py 100.00% <100.00%> (ø)
src/zarr/core/buffer/core.py 83.09% <100.00%> (ø)
src/zarr/core/buffer/cpu.py 100.00% <ø> (ø)
src/zarr/core/buffer/gpu.py 90.00% <ø> (ø)
... and 9 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@d-v-b d-v-b merged commit 7783dc2 into zarr-developers:main Aug 18, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomAugspurger TomAugspurger TomAugspurger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

do we need the ChunkCoords type
2 participants
@d-v-b @TomAugspurger