Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Released on https://github.com/yajra/laravel-datatables-html/releases/tag/v12.0.2 🚀 Thanks!

@Romkabouter 4643244#r163719119, you can publish and override the scripts view as a workaround.

@Seb33300, should we revert this change?

Thanks!

Hi @yajra,
Not sure, but what I understand is: @Romkabouter uses ajax to load the table and scripts.

Now that we are using the native js event DOMContentLoaded, it is triggered on page load only.
When the ajax request is loaded, the event is not triggered again.

And it looks like jQuery works differently with $(function(){

If we revert that PR, this re introduce the Uncaught Cannot extend unknown button type: reset error.

I suggest to move the code that init the datatable in a dedicated function
And then:

// Move the code in a dedicated function
function initDataTables() { ... }
// trigger init
if (document.readyState === "complete") {
    initDataTables();
} else {
    document.addEventListener("DOMContentLoaded", initDataTables);
}

Hi @yajra, Not sure, but what I understand is: @Romkabouter uses ajax to load the table and scripts.

Now that we are using the native js event DOMContentLoaded, it is triggered on page load only. When the ajax request is loaded, the event is not triggered again.

And it looks like jQuery works differently with $(function(){

If we revert that PR, this re introduce the Uncaught Cannot extend unknown button type: reset error.

I suggest to move the code that init the datatable in a dedicated function And then:

// Move the code in a dedicated function
function initDataTables() { ... }
// trigger init
if (document.readyState === "complete") {
    initDataTables();
} else {
    document.addEventListener("DOMContentLoaded", initDataTables);
}

I have made a comment on the change, but indeed when loading via ajax, the event is not triggered. The effect is that the ajax call to get the data is not performed.
I have pinned my version to 12.0.1