Skip to content

Add render-blocking boolean to fetch timing info #1449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 29, 2022
Merged

Add render-blocking boolean to fetch timing info #1449

merged 2 commits into from
Jul 29, 2022

Conversation

@abinpaul1
Copy link
Contributor

@abinpaul1 abinpaul1 commented Jun 2, 2022 •
edited
Loading

These changes are to support addition of a render blocking status field to Perfomance resource timing. Further details are available at w3c/resource-timing#327

For HTML side changes see whatwg/html#7979

(See WHATWG Working Mode: Changes for more details.)

Preview | Diff

@abinpaul1 abinpaul1 marked this pull request as draft June 2, 2022 15:01
This was referenced Jun 2, 2022
Closed
Merged
@abinpaul1 abinpaul1 marked this pull request as ready for review June 10, 2022 05:57
@yoavweiss
Copy link
Collaborator

I think it'd be better if this used the existing Request's render-blocking boolean. For that, I think you need to pass it with the request itself, and not when finalizing the response. Apologies for not catching that earlier.

/cc @xiaochengh for thoughts

@xiaochengh
Copy link
Contributor

I added Request's "render-blocking" as a boolean because I felt the multivalue enum is too Blink-specific.

Here, do we still want to put a multivalue enum on Request (like what Blink currently does), or just use the existing boolean?

@annevk
Copy link
Member

annevk commented Jun 14, 2022

Note that once @noamr's #1413 lands this will have to change somewhat significantly. And I suggest we land that first as it's a rather big change and it seems relatively straightforward to adjust this.

@abinpaul1 abinpaul1 force-pushed the render-blocking-status branch from 0ab8913 to 23030b8 Compare June 18, 2022 15:04
@abinpaul1 abinpaul1 changed the title Pass in render blocking status via finalize and report timing Add render-blocking boolean to fetch timing info Jun 18, 2022
@abinpaul1
Copy link
Contributor Author

I've updated this to use Request's render-blocking boolean and also adjusted for #1413 changes

annevk
annevk reviewed Jul 28, 2022
View reviewed changes
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay modulo this nit. If this suggested change looks okay I'd be happy for @domenic to land this as I'll be away for the next couple weeks.

@abinpaul1 @annevk
Update fetch.bs
ff45bb8 
Co-authored-by: Anne van Kesteren <annevk@annevk.nl>
@domenic domenic merged commit 9bb2ded into whatwg:main Jul 29, 2022
@xiaochengh xiaochengh mentioned this pull request Apr 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@annevk annevk annevk left review comments

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@abinpaul1 @yoavweiss @xiaochengh @annevk @domenic