Run forever socket close fix #1015
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases like
handleDisconnect, theon_errorcallback is called first. If theWebSocketAppis being used in a multithreaded application, we nee to make sure thatself.sockis cleared before calling close, otherwise logic built around the sock being set can cause issues - specifically callingrun_foreveragain, since is checks ifself.sockis set.This was found when using the 3rd party library pysher that uses the websocket-client
As for example code, it isn't particularly easy. but if it's needed I'm sure I can put something together.