Skip to content

feat: Update storage stats with seed file and collection thumbnails #2767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 29, 2025
Merged

feat: Update storage stats with seed file and collection thumbnails #2767

merged 9 commits into from
Jul 29, 2025

Conversation

SuaYoo
Copy link
Member

@SuaYoo SuaYoo commented Jul 23, 2025 •
edited
Loading

Resolves #2733

Changes

Manual testing

  1. Log in as superadmin
  2. Go to org quotas. Verify size for each storage line item is displayed
  3. Go to org with seed files. Verify "Miscellaneous" line item is displayed

Screenshots

Page Image/video
Dashboard Org with quotas and no seed files:
Screenshot 2025-07-24 at 11 16 56 AM
Dashboard Org with quotas and with seed files:
Screenshot 2025-07-24 at 11 16 49 AM
Dashboard Org without quotas and with seed files:
Screenshot 2025-07-24 at 11 17 05 AM
User Guide Screenshot 2025-07-24 at 10 46 37 AM

@SuaYoo SuaYoo requested review from ikreymer, emma-sg and tw4l July 24, 2025 18:18
@SuaYoo SuaYoo marked this pull request as ready for review July 24, 2025 18:20
tw4l
tw4l reviewed Jul 24, 2025
View reviewed changes
Copy link
Member

@tw4l tw4l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvements! I wonder if it's worth including a text row for total at the very bottom as well? It does show under the bar if storage quota is set but feels like an important piece of information to communicate succinctly.

@SuaYoo
Copy link
Member Author

SuaYoo commented Jul 25, 2025

I wonder if it's worth including a text row for total at the very bottom as well?

What do you think about showing the total used only if the quota bar is not present?

Screenshot 2025-07-25 at 10 21 27 AM

Otherwise, displaying the total used twice (in the bar and as a line) can be misleading in its own way, since currently the items displayed also function as a color legend. We could revisit how this data is displayed as related to custom storage work?

@SuaYoo SuaYoo requested a review from tw4l July 25, 2025 17:35
@tw4l
Copy link
Member

tw4l commented Jul 28, 2025

I wonder if it's worth including a text row for total at the very bottom as well?

What do you think about showing the total used only if the quota bar is not present?

Otherwise, displaying the total used twice (in the bar and as a line) can be misleading in its own way, since currently the items displayed also function as a color legend. We could revisit how this data is displayed as related to custom storage work?

Sure, that works!

@ikreymer ikreymer added this to the 1.18 Milestone milestone Jul 28, 2025
@SuaYoo
Copy link
Member Author

SuaYoo commented Jul 28, 2025

@emma-sg @DaleLore added info popover to "misc":

Screenshot 2025-07-28 at 12 02 33 PM

emma-sg
emma-sg approved these changes Jul 28, 2025
View reviewed changes
Copy link
Member

@emma-sg emma-sg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ikreymer ikreymer merged commit ed580c4 into main Jul 29, 2025
27 checks passed
@ikreymer ikreymer deleted the frontend-seed-file-dashboard-stat branch July 29, 2025 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikreymer ikreymer ikreymer approved these changes

@emma-sg emma-sg emma-sg approved these changes

@tw4l tw4l tw4l approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.18 Milestone
Development

Successfully merging this pull request may close these issues.

[Task]: Include seed file size in org dashboard
4 participants
@SuaYoo @tw4l @ikreymer @emma-sg