Skip to content

feat: Duplicate workflows with seed file #2744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 23, 2025
Merged

feat: Duplicate workflows with seed file #2744

merged 5 commits into from
Jul 23, 2025

Conversation

SuaYoo
Copy link
Member

@SuaYoo SuaYoo commented Jul 17, 2025 •
edited
Loading

Resolves #2732

Changes

Allows users to duplicate workflows with a seed file.

Manual testing

  1. Log in as crawler
  2. Go to workflows list
  3. Click a seed file workflow's "..." overflow menu and select "Duplicate Workflow". Verify navigation to new workflow page with "Upload URL List" pre-filled with the seed file
  4. Save. Verify seed file is saved as expected
  5. Click "Actions" -> "Duplicate Workflow". Verify same as 3-4.

Regression tested manually entered URL list and other scope types.

@SuaYoo SuaYoo requested review from ikreymer, emma-sg and tw4l July 17, 2025 03:56
@SuaYoo SuaYoo changed the title wip: Duplicate workflows with seed file feat: Duplicate workflows with seed file Jul 18, 2025
@SuaYoo SuaYoo force-pushed the frontend-upload-seed-url-list branch from 9452102 to 562c571 Compare July 22, 2025 22:00
@SuaYoo SuaYoo force-pushed the frontend-upload-seed-url-list--duplicate-config branch from 8cb54c6 to 4aef51b Compare July 22, 2025 22:02
emma-sg
emma-sg approved these changes Jul 23, 2025
View reviewed changes
Copy link
Member

@emma-sg emma-sg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, seems to work!

@ikreymer ikreymer force-pushed the frontend-upload-seed-url-list branch from 562c571 to 2ae2482 Compare July 23, 2025 02:20
Base automatically changed from frontend-upload-seed-url-list to main July 23, 2025 03:17
@ikreymer ikreymer force-pushed the frontend-upload-seed-url-list--duplicate-config branch from 4aef51b to f23dd6f Compare July 23, 2025 03:19
@ikreymer
Copy link
Member

Nice, working well!

@ikreymer ikreymer merged commit 7df3cb7 into main Jul 23, 2025
27 checks passed
@ikreymer ikreymer deleted the frontend-upload-seed-url-list--duplicate-config branch July 23, 2025 04:20
ikreymer added a commit that referenced this pull request Jul 23, 2025
@ikreymer
quickfix: delete seedfile after the workflow has been deleted, as see…
8ab1768 
…dfile deletion checks that at least 1 workflow exists

noticed in checking #2744
@ikreymer ikreymer mentioned this pull request Jul 23, 2025
Merged
ikreymer added a commit that referenced this pull request Jul 24, 2025
@ikreymer
quickfix: delete seedfile after the workflow has been deleted (#2763)
89027ef 
Since seedfile deletion checks that the seedfile is not used in any
workflow, it should be deleted after the workflow is removed.
noticed in checking #2744
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikreymer ikreymer ikreymer approved these changes

@emma-sg emma-sg emma-sg approved these changes

@tw4l tw4l Awaiting requested review from tw4l

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: Duplicate workflow seed file
3 participants
@SuaYoo @ikreymer @emma-sg