Skip to content

Ensure replay.json returns correct origin for pagesQueryUrl #2741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 16, 2025
Merged

Ensure replay.json returns correct origin for pagesQueryUrl #2741

merged 3 commits into from
Jul 16, 2025

Conversation

ikreymer
Copy link
Member

@ikreymer ikreymer commented Jul 16, 2025 •
edited
Loading

ikreymer added 2 commits July 15, 2025 18:43
@ikreymer
ensure replay.json pagesQueryUrl has correct hostname by using the Ho…
dfa45e7 
…st/Origin header from the API request

fixes #2740, better fix for #2720 avoiding need for separate alias
@ikreymer
fix test typos
387f235
@ikreymer ikreymer mentioned this pull request Jul 16, 2025
Closed
tw4l
tw4l approved these changes Jul 16, 2025
View reviewed changes
Copy link
Member

@tw4l tw4l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be good to test the scheme/x-forwarded-proto header in the tests as well but otherwise, nice fix!

@ikreymer ikreymer merged commit 3af94ca into main Jul 16, 2025
22 checks passed
@ikreymer ikreymer deleted the issue-2740-pass-headers-to-replay-json-endpoints branch July 16, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tw4l tw4l tw4l approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: Ensure correct headers from API for most user-facing /replay.json responses
2 participants
@ikreymer @tw4l