Custom Page Prefix Usability Fixes #2736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- automatically compute prefix from starting URL, if no other prefix is set in custom prefix mode - add '^' to each custom prefix URL, as it is a regex - rename 'Extra URL Prefixes' to just 'URL Prefixes' and adjust help text to indicate that the prefix list is the list that is in scope - fixes #2735, follow up to #2722
tw4l
approved these changes
Jul 15, 2025
There was a problem hiding this comment.
Makes sense and testing well. I added a commit to update the user guide documentation appropriately.
I think these changes are also safe in terms of not breaking existing workflows, since existing custom page prefix workflows created before these changes (e.g. those set on a schedule to run periodically) will still have the "prefix" scopeType set for the first seed, and only new Custom Page Prefix workflows will be affected.
SuaYoo
reviewed
Jul 15, 2025
Co-authored-by: sua yoo <sua@webrecorder.org>
SuaYoo
approved these changes
Jul 15, 2025
emma-sg
approved these changes
Jul 15, 2025
ikreymer
added a commit
that referenced
this pull request
Jul 18, 2025
- ensure auto-added '^' is stripped from custom prefix URLs loaded from db
ikreymer
added a commit
that referenced
this pull request
Jul 19, 2025
- follow-up to: #2736: remove '^' custom prefix URLs to avoid accumulating '^' via utility function - Show URL prefix list in settings for custom prefix scope. - Update user guide with correct custom prefix field. --------- Co-authored-by: sua yoo <sua@webrecorder.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Examples
The following examples demonstrates the new behavior, auto-populating the URL Prefix field:
custom-prefix.mp4
Makes it easy to then adjust the prefix to a subpath instead:
custom-prefix-2.mp4