Skip to content

feat: allow specifying custom annotations on ingress #2725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 25, 2025
Merged

feat: allow specifying custom annotations on ingress #2725

merged 2 commits into from
Jul 25, 2025

Conversation

samczsun
Copy link
Contributor

@samczsun samczsun commented Jul 9, 2025

This allows users who don't use the nginx ingress controller to still configure the built in ingress

@ikreymer
Copy link
Member

Thanks! I think this should be good - can you just add a commented out example in values.yaml?

@ikreymer ikreymer self-requested a review July 25, 2025 19:32
ikreymer
ikreymer approved these changes Jul 25, 2025
View reviewed changes
Copy link
Member

@ikreymer ikreymer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ikreymer ikreymer merged commit feafeae into webrecorder:main Jul 25, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikreymer ikreymer ikreymer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samczsun @ikreymer