Skip to content

fix: Close "please log in" alert when accepting invite #2688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2025

Conversation

SuaYoo
Copy link
Member

@SuaYoo SuaYoo commented Jun 25, 2025

No issue created, quick fix for edge case

Changes

Adds ID to accept page toast messages so that "Please log in ..." message closes once the invite is accepted or declined.

Manual testing

  1. Log in as org admin
  2. Invite user (one you have access to) to an org
  3. Log out and log in as invited user
  4. Click invite link in inbox
  5. Click accept quickly. Verify "Please log in ..." message is replaced with "You've joined ..."

@SuaYoo SuaYoo requested review from ikreymer and emma-sg June 25, 2025 00:07
@SuaYoo SuaYoo moved this to In Review in Webrecorder Projects Jun 25, 2025
@ikreymer ikreymer merged commit f389b9b into main Jun 26, 2025
27 checks passed
@ikreymer ikreymer deleted the frontend-update-log-in-toast branch June 26, 2025 14:49
@github-project-automation github-project-automation bot moved this from In Review to Done! in Webrecorder Projects Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done!
Development

Successfully merging this pull request may close these issues.

3 participants