You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds Storybook in preparation for UI component refactoring.
Manual testing
Run yarn to install dependencies
Run yarn storybook. Verify Storybook loads with button and table components
Screenshots
Page
Image/video
Storybook - Introduction
Storybook - Button
Storybook - Table
Follow-ups
Shoelace assets like icons aren't working yet.
We don't actually use btrix-button as much as btrix-navigation-button, but I added it since it has a simple enough component API and it'd be a step towards mergin the two components.
The reason will be displayed to describe this comment to others. Learn more.
Sweet, this is a great start! Very down to get this merged, though I think eventually I'd like to move this stuff into Hickory — but that's something I'll look into later.
Next steps: Take a moment to review the security alert
above. Review the linked package source code to understand the potential
risk. Ensure the package is not malicious before proceeding. If you're
unsure how to proceed, reach out to your security team or ask the Socket
team for help at support@socket.dev.
Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code.
Mark the package as acceptable risk. To ignore this alert only
in this pull request, reply with the comment
@SocketSecurity ignore npm/replaywebpage@2.2.4. You can
also ignore all packages with @SocketSecurity ignore-all.
To ignore an alert for all future pull requests, use Socket's Dashboard to
change the triage state of this alert.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #2497
Changes
Adds Storybook in preparation for UI component refactoring.
Manual testing
yarnto install dependenciesyarn storybook. Verify Storybook loads with button and table componentsScreenshots
Follow-ups
btrix-buttonas much asbtrix-navigation-button, but I added it since it has a simple enough component API and it'd be a step towards mergin the two components.