Add TUI statusline configuration picker#14286
Open
moirahuang wants to merge 1 commit into
Open
Conversation
This was referenced Jul 25, 2026
Contributor
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
There was a problem hiding this comment.
Overview
This PR adds a local TUI statusline configuration setting, a new TUI picker view for toggling/reordering statusline items, keybinding registration, and unit coverage for defaults and picker behavior.
Concerns
- The PR changes a user-facing TUI surface, but the description's Screenshots / Videos section is empty. For this user-facing change, please include accepted TUI visual evidence such as a terminal transcript, render-to-lines snapshot,
./script/run-tuicapture, screenshot, or short recording demonstrating the picker working end to end.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
moirahuang
force-pushed
the
moira/statusline-question-refactor
branch
from
July 25, 2026 01:13
e5038b7 to
ff0c626
Compare
moirahuang
force-pushed
the
moira/statusline-config-picker
branch
from
July 25, 2026 01:13
69adea6 to
c33c1ee
Compare
moirahuang
added a commit
that referenced
this pull request
Jul 25, 2026
## Description Refactors shared Ask User Question state initialization to accept prefilled drafts keyed by question ID, and adds filtered full-catalog row reordering to the reusable TUI option selector. Existing Ask User Question, permission, and orchestration consumers explicitly ignore reorder events, so this PR is behavior-neutral on its own. ## Linked Issue N/A — stacked prerequisite for #14286. ## Testing - [x] `cargo nextest run -p ai -E test(ask_user_question_session)` — 19 passed. - [x] `cargo nextest run -p warp_tui -E test(option_selector)` — 39 passed. - [x] Formatting and warnings-denied Clippy passed. ## Agent Mode - [x] Warp Agent Mode - This PR was created via Warp's AI Agent Mode CHANGELOG-NONE Co-Authored-By: Oz <oz-agent@warp.dev> Co-authored-by: Oz <oz-agent@warp.dev>
Co-Authored-By: Oz <oz-agent@warp.dev>
moirahuang
force-pushed
the
moira/statusline-config-picker
branch
from
July 25, 2026 01:50
c33c1ee to
3d8ac3f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the local-only TUI statusline settings model and an Ask User Question-style searchable multiselect for toggling and reordering statusline items. The picker and keybindings compile and are tested, but this PR deliberately does not register
/statusline, mount the picker in a session, or render the configuration, so it is behavior-neutral until #14253.Linked Issue
N/A — stacked parent for #14253.
Testing
cargo nextest run -p warp tui_statusline— 2 passed.cargo nextest run -p warp_tui statusline_config_view— 2 passed.cargo clippy -p warp_tui --all-targets --all-features --tests -- -D warnings.Agent Mode
CHANGELOG-NONE
Co-Authored-By: Oz oz-agent@warp.dev