Skip to content

feat(onLongPress): allow delay to be a function #4982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

feat(onLongPress): allow delay to be a function #4982

wants to merge 2 commits into from
+32 −3

Conversation

duralga
Copy link

@duralga duralga commented Aug 23, 2025 •
edited
Loading

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.

Description

Additional context

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. enhancement New feature or request labels Aug 23, 2025
@duralga
Copy link
Author

duralga commented Aug 23, 2025

This Pull Request introduces a new feature that allows the delay option in the onLongPress composable to be a function. This provides more flexibility, enabling users to set a dynamic delay based on the specific PointerEvent.

Specifically, this change:

Adds a new option: delay can now accept a function that receives a PointerEvent as its argument and returns a number (in milliseconds) for the long press duration.

Enables dynamic behavior: A common use case is to set a different delay for touch events (e.g., 500ms) versus mouse events (e.g., 0ms), improving the user experience on different devices.

Includes a new test case: A test has been added to packages/core/onLongPress/index.test.ts to ensure that this new functionality works as expected and correctly handles different pointer types.

This feature was suggested and discussed in the comments of a previous Pull Request, and I believe it will be a valuable addition to the library.

Я добавил также технические детали, которые будут полезны для разработчиков VueUse. Они поймут, что вы не просто изменили код, но и добавили тесты, что очень важно для качественного проекта.

@NoiseFan
Copy link
Contributor

As far as I know, the main language of this project is English, and it will be better to adjust it to English in the comment part!

NoiseFan
NoiseFan reviewed Aug 23, 2025
View reviewed changes
packages/core/onLongPress/index.test.ts
@@ -186,6 +186,30 @@ describe('onLongPress', () => {
expect(onMouseUpCallback.mock.calls[1][0]).toBeGreaterThanOrEqual(500 - 2)
}

// --- Новый тест, который проверяет вашу реализацию ---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For example here

@NoiseFan
Copy link
Contributor

Also, and another pull request #4979 duplicated.

@ilyaliao
Copy link
Member

Thanks for your PR! However, as mentioned above, #4979 is already handling this issue. If you think there are still areas for improvement, feel free to leave your comments there : )

@ilyaliao ilyaliao closed this Aug 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@NoiseFan NoiseFan NoiseFan left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
enhancement New feature or request size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@duralga @NoiseFan @ilyaliao