Skip to content

Correct return type to CustomElementConstructor #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Correct return type to CustomElementConstructor #127

wants to merge 1 commit into from

Conversation

steverep
Copy link

@steverep steverep commented Jan 9, 2023

Fixes #126

bghandou
bghandou reviewed Sep 22, 2023
View reviewed changes
types/index.d.ts
@@ -3,6 +3,6 @@ import _Vue, { Component, AsyncComponent } from 'vue'
declare function wrap(
Vue: typeof _Vue,
Component: Component | AsyncComponent
): HTMLElement
): CustomElementConstructor
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
): CustomElementConstructor
): typeof HTMLElement

This will fix the return typing issue, and also is more accurate. Here is why:
wrap() function returns this, which is indeed a type of HTMLElement. This type declaration will indeed fix the lack of congruency.

@bghandou bghandou mentioned this pull request Sep 22, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@bghandou bghandou bghandou left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Return type of HTMLElement is not correct
2 participants
@steverep @bghandou