Skip to content

fix(vscode): Improved reliability of handling extension activation race #5588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 20, 2025

Conversation

johnsoncodehk
Copy link
Member

@johnsoncodehk johnsoncodehk commented Aug 4, 2025

Resolves #5587

Changes

  1. Using the onLanguage activation event instead of plaintext language configuration more reliably ensures that the Vue extension activates before the TypeScript extension.
  2. Instead of automatically executing workbench.action.restartExtensionHost, users are now prompted to manually restart the extension host (the need for restarts after switching to the onLanguage activation event should be reduced).

Copy link

pkg-pr-new bot commented Aug 4, 2025

Open in StackBlitz

vue-component-meta

npm i https://pkg.pr.new/vuejs/language-tools/vue-component-meta@5588

vue-component-type-helpers

npm i https://pkg.pr.new/vuejs/language-tools/vue-component-type-helpers@5588

@vue/language-core

npm i https://pkg.pr.new/vuejs/language-tools/@vue/language-core@5588

@vue/language-plugin-pug

npm i https://pkg.pr.new/vuejs/language-tools/@vue/language-plugin-pug@5588

@vue/language-server

npm i https://pkg.pr.new/vuejs/language-tools/@vue/language-server@5588

@vue/language-service

npm i https://pkg.pr.new/vuejs/language-tools/@vue/language-service@5588

vue-tsc

npm i https://pkg.pr.new/vuejs/language-tools/vue-tsc@5588

@vue/typescript-plugin

npm i https://pkg.pr.new/vuejs/language-tools/@vue/typescript-plugin@5588

commit: ec7c489

@johnsoncodehk johnsoncodehk marked this pull request as ready for review August 20, 2025 06:42
@johnsoncodehk johnsoncodehk changed the title fix(vscode): remove restartExtensionHost command usage fix(vscode): Improved reliability of handling extension activation contention Aug 20, 2025
@johnsoncodehk johnsoncodehk merged commit c742a1c into master Aug 20, 2025
10 checks passed
@johnsoncodehk johnsoncodehk deleted the remove-restartExtensionHost branch August 20, 2025 06:44
@johnsoncodehk johnsoncodehk changed the title fix(vscode): Improved reliability of handling extension activation contention fix(vscode): Improved reliability of handling extension activation race Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extension host unexpectedly restarts when opening vue/html files in versions 3.0.2 and 3.0.5(latest version)
1 participant